Change UIA backend to use RawViewWalker instead of FindAll #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use iter_children for avoid code duplication
Debug prints, need testing and performance optimizations.
It previously received all descendants tree, and then filtered it. Usually appears on Qt apps.
RawTreeWalker finds more elements than FindAll method. This causes tests failure because best_match prefers a Pane element instead of Static.
|
I tried to compare the performance of both methods and got the following results: Test application: modified widgets\mainwindows\mainwindow example from Qt5 with number of dock windows and nested groupboxes specified via command line arguments Window with 7 children elements, average tree depth 2
Window with 12 children elements, average tree depth 7
Window with 67 children elements, average tree depth 62
Source of used benchmarks located here |
Codecov Report
@@ Coverage Diff @@
## atspi #1001 +/- ##
==========================================
- Coverage 95.06% 89.20% -5.86%
==========================================
Files 58 58
Lines 22100 22037 -63
==========================================
- Hits 21009 19659 -1350
- Misses 1091 2378 +1287 |
airelil
requested changes
Oct 30, 2020
because original method won't be restored if test asserts and it may affect to other tests
vasily-v-ryabov
approved these changes
Nov 1, 2020
|
@eltimen thanks for measurements! Please create a Wiki page with these numbers and put a link on it here. |
https://github.com/pywinauto/pywinauto/wiki/Performance-measurements-(draft) |
airelil
approved these changes
Nov 2, 2020
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Sep 19, 2023
In pywinauto#207, the `cache_enable` argument was added to the constructor, propagating to `children` and `descendants`. However, when `iter_children` and `iter_descendants` were introduced in pywinauto#475, `cache_enable` wasn't implemented to propagate. From reviewing past issues and PRs, it appears that not propagating `cache_enable` was unintentional and simply overlooked. pywinauto#1001 and pywinauto#1012 refactored the code without changing the current behavior, resulting in a complex conditional implementation.
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Sep 19, 2023
In pywinauto#207, the `cache_enable` argument was added to the constructor, propagating to `children` and `descendants`. However, when `iter_children` and `iter_descendants` were introduced in pywinauto#475, `cache_enable` wasn't implemented to propagate. From reviewing past issues and PRs, it appears that not propagating `cache_enable` was unintentional and simply overlooked. pywinauto#1001 and pywinauto#1012 refactored the code without changing the current behavior, resulting in a complex conditional implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods
children()anddescendants()of the UIAElementInfo changed to useIUIAutomation::RawViewWalkerinstead ofIUIAutomationElement::FindAll.This allows to find more elements than FindAll returns (for example, solves the problem mentioned in #644)
Related issues #644 #696