Bugfix for get_sample_local() #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was incorrect, and was only able to pass testing as it return a size 0 grid in all cases. This PR corrects that bug and shores up the testing.
This bit of the API is now tested by two tests which:
(1) ~ Make sure the "width" argument scales as theory suggests. Making a grid twice as wide leads to a non-linear expansion (although for small widths this is very close to 2^3 = 8)
(2) ~ Make sure some obvious rotation are out (by size) and in (near the far end, but in)
(3) Makes sure the center argument obeys as expected. If width=x and the center is z, you expect all outputs to be within x of the rotation z.