Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dask following dask 2021.8.1 #418

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Aug 22, 2021

Description of the change

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in doc/changelog.rst.
  • New contributors are added to .all-contributorsrc and the table is regenerated.

@hakonanes
Copy link
Member

Thank you, @ericpre!

Is it OK if I update this PR with these changes:

  1. Add you to the All Contributors table with code and maintenance badges?
  2. Add a changelog entry and add your name "Eric Prestat" to the package credits in release.py?

@hakonanes hakonanes added the maintenance This relates to package maintenance label Aug 23, 2021
@hakonanes hakonanes added this to the v0.5.0 milestone Aug 23, 2021
@hakonanes
Copy link
Member

This PR will close #359.

@ericpre
Copy link
Contributor Author

ericpre commented Aug 23, 2021

Yes, sure!

@ericpre ericpre changed the base branch from develop to main August 23, 2021 08:17
@hakonanes
Copy link
Member

I would appreciate it if you could change the base branch back to develop. After v0.5, these changes would go to main and we would immediately release a patch.

@hakonanes
Copy link
Member

I would appreciate it if you could change the base branch back to develop. After v0.5, these changes would go to main and we would immediately release a patch.

So the guidelines in the contributing guide is wrong until v0.5. I'm sorry for the confusion.

@ericpre ericpre changed the base branch from main to develop August 23, 2021 08:32
@ericpre
Copy link
Contributor Author

ericpre commented Aug 23, 2021

Done.

@ericpre
Copy link
Contributor Author

ericpre commented Aug 23, 2021

Does it mean the next release will be done once the 0.5 milestone is completed?

@hakonanes
Copy link
Member

Does it mean the next release will be done once the 0.5 milestone is completed?

Good point. With the EBSD orientation refinement functionality implemented in #387, the improvements to simulated pattern dictionary generation in #405, and the upcoming improvements in #419 (plan to finish within the weekend), I think we should release v0.5 with these changes. So hopefully within the weekend or early next week. I'll update the milestone now, thanks for pointing that out.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit 4b1dc4f into pyxem:develop Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants