Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppetfile::update_module_ref assumes that a :ref already exist in Puppetfile #7

Closed
tremblaysimon opened this issue Nov 10, 2014 · 4 comments

Comments

@tremblaysimon
Copy link

At first glance it's not mandatory to supply a :ref for a module in the R10K Puppetfile.

For now reaktor seems to work well only if a :ref has been specified.

It's not a big issue and the workaround is simple since we only have to add a :ref to all module in the R10K Puppetfile and the regex will work as expected.

@pzim
Copy link
Owner

pzim commented Nov 20, 2014

Reaktor is definitely opinionated, and this is no exception. I'll leave this open for a few weeks to see if it's impacting others as well. Thanks

@tremblaysimon
Copy link
Author

After thinking about it, I realize that Reaktor must be opinionated about that. If I have a minute I would like to add some simple code to add the :ref line if it's missing or throw an error.

@pzim
Copy link
Owner

pzim commented Mar 13, 2015

@tremblaysimon - is this still an ongoing problem for you? If not, I can close this out.

@tremblaysimon
Copy link
Author

Yes we can close that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants