Splines and Functional Form

[pzivich]

When looking at functional form plots for spline models, they display oddly. Either something is going wrong in the generation of the matplotlib object or the spline calculation is doing something unexpected....

[pzivich]

This is occurring since the plot functions uses var input but for truly continuous variables you have to do some sort of binning as the function currently works. Since the binning variable var is the categorical variable, it causes issues with the plots...

For a fix, I will need to

1. Add option to automatically bin (write the code to do this and label everything as the median of that interval)
2. Grab the bins (over distinct categories) and generate the C(...) estimate from statsmodels
3. Fit the user specified model
4. Generate plots so they are estimated and relevant to the VALUES and not the categories

[pzivich]

Error was in functional form plot. Splines work properly. Have added an option to the functional form plotter to auto-categorize continuous variables for LOWESS generated line. Now the functional automatically generates this, unless the user specifies that the variable is discrete bin = False