Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit tests for tf_utils and qt_utils #92

Open
GlaserN opened this issue May 19, 2021 · 1 comment
Open

Explicit tests for tf_utils and qt_utils #92

GlaserN opened this issue May 19, 2021 · 1 comment
Labels
code-quality General code quality related issues and PRs

Comments

@GlaserN
Copy link
Collaborator

GlaserN commented May 19, 2021

Is your feature request related to a problem? Please describe.
We need explicit tests and extensive tests for the functions in tf_utils and qt_utils. Code coverage is not given by the current tests and several functions are not curretly working, correctly, e.g. tf_superoper_average_fidelity.
https://github.com/q-optimize/c3/blob/dev/c3/utils/tf_utils.py#L802-L807
As those functions are the backbone for all calculations good tests would be essential for all computations.

Describe the solution you'd like
Write tests

Describe alternatives you've considered

Additional context

@lazyoracle lazyoracle added the code-quality General code quality related issues and PRs label May 19, 2021
@lazyoracle
Copy link
Member

Some tests for tf_utils functions were added in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality General code quality related issues and PRs
Projects
None yet
Development

No branches or pull requests

2 participants