-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for qt_utils #112
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #112 +/- ##
==========================================
+ Coverage 57.57% 58.44% +0.86%
==========================================
Files 36 36
Lines 5304 5304
==========================================
+ Hits 3054 3100 +46
+ Misses 2250 2204 -46
Continue to review full report at Codecov.
|
Can you Assuming you have the local repo set up as per the contribution guidelines: git checkout dev
git fetch upstream dev
git checkout test-qt_utils
git rebase upstream/dev
git push -f origin test-qt_utils |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and very thorough when @lazyoracle s minor comment is addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge.
Congratulations on the first PR! 🥳
What
Add tests for
utils/qt_utils.py
Why
Part of #92
How
Adds unit tests for some utility functions in qt_utils, which were not covered by tests yet.
Notes
I tried to test the properties of the function's results as described in #71, so that the tests are independent of the function's implementation. For functions which can work with arbitrary dimensions (e.g.
xy_basis
), the test is repeated for some dimensions to be sure, e.g dim=3, 5, 10, 100. Going through all dimensions up to some max value would probably make the test run unnecessary long.