Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New propagation library created #99

Merged
merged 15 commits into from
Jun 15, 2021
Merged

New propagation library created #99

merged 15 commits into from
Jun 15, 2021

Conversation

frosati1
Copy link
Collaborator

What: propagation library created
How: moved code related only with propagation from tf.utils to propagation.py in libraries
Why: cleaner code

@CLAassistant
Copy link

CLAassistant commented May 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@lazyoracle lazyoracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests to the updated propagation.py library, following the basic tests currently present in our test suite. We can iterate on top of it.

c3/libraries/propagation.py Outdated Show resolved Hide resolved
c3/libraries/propagation.py Outdated Show resolved Hide resolved
@lazyoracle
Copy link
Member

@lazyoracle lazyoracle added this to the 1.3 milestone May 28, 2021
@lazyoracle lazyoracle added the enhancement New feature or request label May 28, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #99 (a2c46f7) into dev (8369d14) will increase coverage by 6.09%.
The diff coverage is 27.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #99      +/-   ##
==========================================
+ Coverage   51.48%   57.57%   +6.09%     
==========================================
  Files          36       36              
  Lines        5409     5304     -105     
==========================================
+ Hits         2785     3054     +269     
+ Misses       2624     2250     -374     
Impacted Files Coverage Δ
c3/utils/tf_utils.py 48.23% <ø> (+13.06%) ⬆️
c3/libraries/propagation.py 26.22% <26.22%> (ø)
c3/experiment.py 62.27% <100.00%> (+3.64%) ⬆️
c3/libraries/fidelities.py 21.65% <100.00%> (+0.25%) ⬆️
c3/optimizers/c1.py 73.73% <0.00%> (-7.43%) ⬇️
c3/libraries/chip.py 45.41% <0.00%> (-0.20%) ⬇️
c3/utils/parsers.py
c3/generator/devices.py 64.83% <0.00%> (+0.18%) ⬆️
c3/utils/utils.py 65.04% <0.00%> (+0.40%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8369d14...a2c46f7. Read the comment docs.

@lazyoracle lazyoracle merged commit d1ed398 into q-optimize:dev Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants