Physics simulation for Qiskit circuits #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 2 alerts when merging 0370d01 into af38dae - view on LGTM.com fixed alerts:
|
|
When we talk next time, please explain this to me.
…On Wed, 29 Dec 2021, 5:03 Anurag Saha Roy, ***@***.***> wrote:
What
Physics simulation for Qiskit circuits
Why
Simulating qiskit circuits by solving full physical dynamics of the system
model (incl of classical electronics and imperfections) provies an easy
interface to the rich simulator of c3-toolset
How
Use the (now no longer) new methods for evaluating qasm representation of
sequences
Remarks
Add notes on possible known quirks/drawbacks of this solution. If this
introduces an API-breaking change, please provide an explanation on why it
is necessary to break API compatibility and how users should update their
notebook/script workflows once this PR is merged.
Checklist
Please include and complete the following checklist. Your Pull Request is
(in most cases) not ready for review until the following have been
completed. You can create a draft PR while you are still completing the
checklist. Check the Contribution Guidelines
<https://github.com/q-optimize/c3/blob/dev/CONTRIBUTING.md> for more
details. You can mark an item as complete with the - [x] prefix
- Tests - Added unit tests for new code, regression tests for bugs and
updated the integration tests if required
- Formatting & Linting - black and flake8 have been used to ensure
styling guidelines are met
- Type Annotations - All new code has been type annotated in the
function signatures using type hints
- Docstrings - Docstrings have been provided for functions in the
numpydoc style
- Documentation - The tutorial style documentation has been updated to
explain changes & new features
- Notebooks - Example notebooks have been updated to incorporate
changes and new features
- Changelog - A short note on this PR has been added to the Upcoming
Release section
------------------------------
You can view, comment on, or merge this pull request online at:
#165
Commit Summary
- 7744aca
<7744aca>
use name field like single qubit gates
- 286edcc
<286edcc>
ensure device has enough qubits for circuit
- 86b2b5d
<86b2b5d>
ad-hoc hardcoded basis gates
- e9eecd5
<e9eecd5>
create c3 experiment object and compute propagators
- 52eb787
<52eb787>
convert and evaluate instructions in qasm style
- f21f7c3
<f21f7c3>
remove redundant conversion to c3 legacy style instructions
- 4309f67
<4309f67>
bump versions and remove mypy dependencies
- 7ebfeac
<7ebfeac>
config file for qiskit physics simulations
- 0ce0dd9
<0ce0dd9>
basic test for qiskit physics simulation
- a83f47b
<a83f47b>
process circuit and obtain output probabilities
- 6b9d1b6
<6b9d1b6>
cleanup TODOs and leftovers
- d31b750
<d31b750>
show circuit output for debugging
- f11aef6
<f11aef6>
ignore mypy warning in pwc
- 0370d01
<0370d01>
create a local circuit for testing
File Changes
(6 files <https://github.com/q-optimize/c3/pull/165/files>)
- *M* .pre-commit-config.yaml
<https://github.com/q-optimize/c3/pull/165/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9>
(14)
- *M* c3/experiment.py
<https://github.com/q-optimize/c3/pull/165/files#diff-beef00f09cb4cffa20b28ab61f6f0233e2fdc09f263d5bb033947c6afe864d77>
(2)
- *M* c3/libraries/propagation.py
<https://github.com/q-optimize/c3/pull/165/files#diff-1b931076821f8cb9809c2d79c339bb9dc5dbd606993405e2c346f8388404e3d6>
(4)
- *M* c3/qiskit/c3_backend.py
<https://github.com/q-optimize/c3/pull/165/files#diff-7a9f4483ed1359fe5e81e06dba7130e90b71c9a33a35a44c9f513c7157b0aa14>
(36)
- *A* test/qiskit.cfg
<https://github.com/q-optimize/c3/pull/165/files#diff-d9784c67864ede4df0a65c7e6a601e643ebeef3373ce820b790d44bc8773d53a>
(29)
- *M* test/test_qiskit.py
<https://github.com/q-optimize/c3/pull/165/files#diff-af951b133417b900925a33f3be5221547017b3904bfe26253a46249bb7f63688>
(13)
Patch Links:
- https://github.com/q-optimize/c3/pull/165.patch
- https://github.com/q-optimize/c3/pull/165.diff
—
Reply to this email directly, view it on GitHub
<#165>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH3Q4IAOROZC3NTSKG4F3LUTJ3ANANCNFSM5K5FFLLQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Codecov Report
@@ Coverage Diff @@
## dev #165 +/- ##
==========================================
+ Coverage 71.81% 72.22% +0.40%
==========================================
Files 36 36
Lines 5475 5476 +1
==========================================
+ Hits 3932 3955 +23
+ Misses 1543 1521 -22
Continue to review full report at Codecov.
|
|
This pull request fixes 2 alerts when merging 1ca3732 into af38dae - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging d5da67f into af38dae - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging eac7c24 into af38dae - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Physics simulation for Qiskit circuits
Why
Simulating qiskit circuits by solving full physical dynamics of the system model (incl of classical electronics and imperfections) provies an easy interface to the rich simulator of
c3-toolsetHow
Use the (now no longer) new methods for evaluating qasm representation of sequences
Remarks
Pending TODOs
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the
- [x]prefixblackandflake8have been used to ensure styling guidelines are metnumpydocstyle