Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Deploy tasks #338

Merged
merged 67 commits into from
May 8, 2019
Merged

[WIP] Deploy tasks #338

merged 67 commits into from
May 8, 2019

Conversation

mathieuboudreau
Copy link
Member

@mathieuboudreau mathieuboudreau commented Apr 17, 2019

Work in progress - created a pull request to try and trigger a readthedocs build.

@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage decreased (-0.7%) to 43.042% when pulling 55e4cdb on deploy_tasks into 3afab2f on master.

@agahkarakuzu
Copy link
Member

@mathieuboudreau this is ready to be merged, waiting for your revision. Upon merge, I will move the tag v2.3.0 and release.

@mathieuboudreau
Copy link
Member Author

@agahkarakuzu would it be possible to write a quickmoxtest for qMRgenJNB.m? It's not being covered at all, and dropped the coverage by almosr 1%

@mathieuboudreau
Copy link
Member Author

@agahkarakuzu I can't review the PR, since I created it. Looked at the code, and I see no major issues that stand out to me. I don't really know how to test this since it has nothing to do with qMRLab itself or the GUI, so you're best to decide to approve if you think it is ready.

@agahkarakuzu
Copy link
Member

@mathieuboudreau I will add a quickmoxtest, then will be ready to merge.

@agahkarakuzu
Copy link
Member

@mathieuboudreau I've pushed the test to the quickMoxTests, after release I can make that use data that already has been donwloaded (by qMRgenBatch) to save some time. But for now, it should solve coverage issue.

@agahkarakuzu agahkarakuzu merged commit 592127f into master May 8, 2019
@agahkarakuzu agahkarakuzu deleted the deploy_tasks branch February 23, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants