[regression] segfault during a video call #3527
Comments
Can you try with ffmpeg 3.0.2-2 or later? |
I can, but it's not a problem with FFmpeg. Stuff crashes with the same FFmpeg version with which it worked before, and the only thing that has changed is qTox. |
Ok. I can't reproduse |
steps:
|
git bisect
Points to 294bdab cc @b4n |
It looks highly unlikely to me this commit is the direct cause of the issue (unless there's a particular string buffer issue there, but 1) I don't think so, 2) it would likely crash way before). I would rather guess that something like x11grab didn't work before (as it would be using an invalid source) and now it works it shows a crash inside the grab/feed code. Do the x11grab actually work without that commit? What is the value of FWIW, it works fine here with EchoBot, |
Yes.
$ echo $DISPLAY
:0.0
Dunno. The only relevant thing before the crash when video-calling:
When going into the settings:
↑ that On the commit that does work:
Interesting – after going into settings once and re-selecting video device, the crash is gone – I guess the crash was due to qTox failing to open saved video device, or something? |
I don't get how there can be an swscale warning before an open device debug message, but well, I don't know the code so well.
Quickly looking at the code suggests that if the saved device is not found, it'll use the first device of the list of available devices. So probably not screen grabbing. (https://github.com/tux3/qTox/blob/master/src/video/cameradevice.cpp#L339)
This seems to come from the V4L2 platform code: https://github.com/tux3/qTox/blob/master/src/platform/camera/v4l2.cpp#L204 |
Oddly enough, |
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Fixed warning from qTox#3527.
Problem with video device == "None". Reproduced by @zetok with echobot (for example). Crashed on received frame.
But when zetok can reproduce crash this line don't executed |
Did bisect again, with
|
I see 2 differences in logic here: I have no idea what it actually changes in practice, but it's definitely a little more than style fix. |
And confused indices |
Does it? I don't see it, it renamed the |
No, you are right. Seems I tired
|
Brief Description
OS: Gentoo Linux amd64
qTox version: 1.4
Commit hash: f970bb5
toxcore: 0.0.0
Qt: 5.5.1
Reproducible: Always
Steps to reproduce
Observed Behavior
segfault
Expected Behavior
video call should start
Additional Info
(links, images, etc go here)
bt:
The text was updated successfully, but these errors were encountered: