This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
[regression] Some profiles fail to connect after the upgrade to 1.10.0 #4385
Labels
Milestone
Comments
yurivict
changed the title
yurivict
changed the title
|
Do you use proxy? |
|
There's no proxy. |
|
I also have the same error, regardless of whether proxy is used. |
yurivict
changed the title
|
@zetok can you test with a fresh nodes list? |
|
Downgrading toxcore to 0.1.7 fixes problem. |
could someone run a git bisect to figure out the breaking commit? |
|
I can confirm that downgrading toxcore to 0.1.7 fixes the problem. |
|
Downgrading qTox to 1.9.0 also fixes the problem. |
|
Just an observation (it might not be what causes this issue) but qTox's bootstrap node list is a bit outdated, probably about of half of the nodes don't exist anymore. 31 nodes were removed from nodes.tox.chat as they were offline for over 1 month. |
|
It would be nice if qTox reported the exact error that |
|
The only reasons why |
|
@yurivict do you have "Creating a new profile" or "Loading user profile" in your log? |
|
Now the current head works for me. |
|
Now it still fails several times, but later it connects. |
|
It's qTox issue. For some reason it passes NULL as public key to I have made the following change on top of the commit that current qTox download is based on nurupo@246fd9f Here is the log of the modified qTox As you can see, |
|
The bug was introduced by d126b18 commit. The bug is in line Line 397 in d126b18
|
nurupo
added a commit
to nurupo/qTox
that referenced
this issue
May 11, 2017
Revert a bug introduced in d126b18 where qTox calls tox_bootstrap() and tox_add_relay() with an invalid argument, which results in qTox not connecting to the bootstrap nodes from its list of bootsrap nodes and therefore failing to connect to the Tox DHT network in the case when that list is the only source of nodes to connect to. The invalid argument is node's public key, which is non-nullable but is passed a null due to invalid ToxPk object being constructed. ToxPk's constructor expects the QByteArray argument to be the byte representation of a public key, but a textual representation is passed to it instead, which creats an invalid ToxPk that resolves to null when queried for public key's bytes for calls to tox_bootstrap() and tox_add_relay(). Fixes qTox#4385
Closed
sudden6
pushed a commit
to sudden6/qTox
that referenced
this issue
May 13, 2017
Revert a bug introduced in d126b18 where qTox calls tox_bootstrap() and tox_add_relay() with an invalid argument, which results in qTox not connecting to the bootstrap nodes from its list of bootsrap nodes and therefore failing to connect to the Tox DHT network in the case when that list is the only source of nodes to connect to. The invalid argument is node's public key, which is non-nullable but is passed a null due to invalid ToxPk object being constructed. ToxPk's constructor expects the QByteArray argument to be the byte representation of a public key, but a textual representation is passed to it instead, which creats an invalid ToxPk that resolves to null when queried for public key's bytes for calls to tox_bootstrap() and tox_add_relay(). Fixes qTox#4385 (cherry picked from commit 4e5b191)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Some profiles fail to connect in 1.10.0, see log below.
Some other instance connect fine.
This is a show-stopper regression.
The text was updated successfully, but these errors were encountered: