New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert.py #2

Closed

qalle2 opened this issue Oct 20, 2022 · 0 comments

Owner

qalle2 commented Oct 20, 2022

line 147: get_tiles(): document the format of returned values
line 159: first split "i" to "x" & "y" for clarity
lines 163-208: move to a fn of its own?
lines 225-236: move to a fn of its own
line 269: print(): add "file=sys.stderr"
line 283: asminstr(): just inline this (or no indentation at all?)
lines 299-300: swap with lines 301-302, do it without a loop
lines 337-341: use collections.Counter().most_common() instead

qalle2 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment