Improve the example InvitesTest #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InvitesTest example used a hardcoded aggregate id of 1 in each tests, which also corresponds to the default id in the Broadway\CommandHandling\Testing\Scenario, making it not quite so obvious as to how to work with the real aggregate id when doing scenario testing. This commit changes the InvitesTest to generate a new UUID in each test and passes it through to Scenario::withAggregateId() to give a better (more real-world) example of the proper way to use the Scenario class
|
Made a mess trying to squash already merged commits in #65 so closed that and cleaned up and resubmitted here |
|
👍 |
fritsjanb
added a commit
that referenced
this pull request
Oct 23, 2014
Improve the example InvitesTest
|
👍 Thanks again @mbadolato |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InvitesTest example used a hardcoded aggregate id of 1 in each
tests, which also corresponds to the default id in the
Broadway\CommandHandling\Testing\Scenario, making it not quite so
obvious as to how to work with the real aggregate id when doing
scenario testing.
This commit changes the InvitesTest to generate a new UUID in each
test and passes it through to Scenario::withAggregateId() to give
a better (more real-world) example of the proper way to use the
Scenario class