Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 color look like errata #18163

Closed
b-user opened this issue Dec 6, 2022 · 10 comments
Closed

2 color look like errata #18163

b-user opened this issue Dec 6, 2022 · 10 comments
Labels
Look and feel Affect UI "Look and feel" only without changing the logic

Comments

@b-user
Copy link

b-user commented Dec 6, 2022

qBittorrent & operating system versions

qBittorrent: 4.5.0

What is the problem?

https://raw.githubusercontent.com/qbittorrent/qBittorrent/master/src/icons/view-refresh.svg
the image consists of 2 colors:
#1e90ff and #4285f4
the different color of the arrow looks like an mistake

2

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

@b-user
Copy link
Author

b-user commented Dec 6, 2022

similar situation with browser-cookies.svg:
https://raw.githubusercontent.com/qbittorrent/qBittorrent/master/src/icons/browser-cookies.svg
same 2 color (like in view-refresh.svg): "#1e90ff" and "#4285f4"
fill="#1e90ff" stroke="#4285f4" stroke-width=".055"
but stroke-width=".055" - practically invisible, I think this color should not be different.
I think it wasn't a purposeful stroke with a different color.

In addition, these colors look very similar
2blue

if you change the fill to fill="#888", it will look like this:
browser-cookies

@b-user b-user changed the title 2 color look like errara 2 color look like errata Dec 6, 2022
@thalieht thalieht added the Look and feel Affect UI "Look and feel" only without changing the logic label Dec 6, 2022
@b-user
Copy link
Author

b-user commented Dec 6, 2022

@now-im, Could you comment please ?

@xavier2k6
Copy link
Member

@now-im Please review all other icons including WebUI icons for any other discrepancies.

@Mazino-Urek
Copy link
Contributor

I don't have much time now. For now, these icons don't pose many problems. I would push an incremental update to some icons in a single PR in the future.

@PaulCoddington
Copy link

PaulCoddington commented Dec 8, 2022

Cosmetically, some of the new icons are a bit too saturated for comfortable viewing on a calibrated sRGB monitor and, as a result, glow like lightbulbs on a wide gamut monitor (BT.2020).

At some point they could probably do with being modernized to move away from harsh high saturated colours to something more modern/pastel that works for all monitors.

But in the meantime, it is all cosmetic detail and the performance improvement and ability to share resources with other applications in the latest Qt6/libtorrent2 version is quite impressive.

@b-user
Copy link
Author

b-user commented Dec 13, 2022

, it is all cosmetic

one team works on the images, and another team writes the code. I help in any way I can - I'm looking for oddities in the images. I can't help with the code.

I am grateful to @now-im for the work. The previous icon update was 5 years ago.

@Mazino-Urek
Copy link
Contributor

Mazino-Urek commented Dec 14, 2022

For the record, if you go through all of my PRs over the year, I pitched muted colors directly taken from the logo of Microsoft and Google. These companies go to great lengths in order to get the color science right. However, the community liked brighter colors and that stayed.
I will try to fix these two icons soon.

@b-user
Copy link
Author

b-user commented Dec 14, 2022

I saw this #15769 (comment)
Well, tastes differ.

@xavier2k6
Copy link
Member

Well, tastes differ.

That we can agree on, just like all transfer list text colors were changed afterwards.

The mix of 2 colors was not my doing......I believe this was just a simple oversight & can be resolved easily.

@now-im Can you reverse the direction of the stalled filter icon to be consistent with the other two ref.: #18222

@Mazino-Urek
Copy link
Contributor

I am only talking about icon color, and I have no problem with the current situation. Communities decision is final.

glassez pushed a commit to glassez/qBittorrent that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Development

No branches or pull requests

5 participants