Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reorder the 'Name' column under Qt5 #2835

Closed
sledgehammer999 opened this issue Apr 5, 2015 · 15 comments
Closed

Cannot reorder the 'Name' column under Qt5 #2835

sledgehammer999 opened this issue Apr 5, 2015 · 15 comments
Labels
Qt bugs Bug resides in Qt library

Comments

@sledgehammer999
Copy link
Member

The title says it all.

I discovered this while testing the fix for #2340. I haven't dug into it. A soft(?) dependency for v3.2.0.

PS: This may need a fresh install to manifest.

@sledgehammer999 sledgehammer999 added this to the v3.2.0 milestone Apr 5, 2015
@sledgehammer999 sledgehammer999 added the Qt bugs Bug resides in Qt library label Apr 10, 2015
@sledgehammer999
Copy link
Member Author

@pmzqla can you confirm on your machine?

@pmzqla
Copy link
Contributor

pmzqla commented Apr 10, 2015

Yes, same here.

EDIT: It happens everywhere for the first column, even in "Trackers" where the first column is "#".
EDIT2: https://bugreports.qt.io/browse/QTBUG-33974

@sledgehammer999
Copy link
Member Author

Supposedly QTreeView::setTreePosition with a value of -1 should fix this but I it doesn't.
Unless I don't understand the docs correctly.

Rant: Are they stupid? If setRootIsDecorated() is set to false, they should automatically allow the moving of the first column. Ideally the treestructure shouldn't be counted as a column at all. It should be part of the widget/view. Qt seems a very well though out API. I wonder how they didn't see this!?!?!

@pmzqla
Copy link
Contributor

pmzqla commented Apr 10, 2015

qt/qtbase@e0fc088
It seems it's just not possible. The hack in the commit message works though.

sledgehammer999 added a commit that referenced this issue Apr 11, 2015
This reverts commit 86f9cc1.

Conflicts:
	configure
@sledgehammer999
Copy link
Member Author

I chose not to switch to qt5(by default) for official builds due to this.

@sledgehammer999 sledgehammer999 removed this from the v3.2.0 milestone Apr 11, 2015
@davispuh
Copy link

Seems to be working fine with Qt 5.5.1

@sledgehammer999
Copy link
Member Author

@davispuh Did you try to reorder your first column? Does it work?

@davispuh
Copy link

yeah
screenshot

@pmzqla
Copy link
Contributor

pmzqla commented Jul 23, 2015

You can because that's not the actual first column. The first column is "#", which is hidden unless you enable torrent queuing from the settings. Try the same in the bottom panels, e.g. Tracker.

I quickly looked at the source code of Qt5.5 and the code that prevents movements of the first column is still there.

@davispuh
Copy link

indeed, can't move # but that's not big deal and Name is movable.

@ngosang
Copy link
Member

ngosang commented Jul 23, 2015

This bug is going to be fixed in Qt? If not we can add a new column with size 0 in the first column or some hack.

@pmzqla
Copy link
Contributor

pmzqla commented Jul 23, 2015

It's done on purpose, so I don't think it's going to be "fixed". See the commit I linked here above for more info, it also shows a working hack.

@sledgehammer999
Copy link
Member Author

@pmzqla IIRC trackers/peers/content columns cannot be moved anyway.

@davispuh All columns should be movable.

@ngosang
Copy link
Member

ngosang commented Aug 29, 2015

@sledgehammer999 I think Qt developers are not going to allow reordering the first column. Last week they ported almost all applications included in the KDE desktop to Qt5 (around 150 apps) and in Dolphin (the default file explorer) and in other apps you can't move the first column.

@sledgehammer999
Copy link
Member Author

@ngosang I saw your earlier post about the hack and was pondering over it while on vacation. Today I'll test if adding another dummy column first and hiding it solves the problem. If it does I'll commit it and close this.

sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Aug 30, 2015
@qbittorrent qbittorrent locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Qt bugs Bug resides in Qt library
Projects
None yet
Development

No branches or pull requests

4 participants