Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Bytes/s with KiB/s in the adding torrent dialogs in WebUI #10618

Merged
merged 1 commit into from
May 12, 2019
Merged

Replace Bytes/s with KiB/s in the adding torrent dialogs in WebUI #10618

merged 1 commit into from
May 12, 2019

Conversation

jerrymakesjelly
Copy link
Contributor

Closes #10017.

Reasons:

  1. Nowadays the Internet speed is usually in KiB/s or MiB/s, so it would be more reasonable to use KiB/s as the basic speed unit.
  2. The speed limit dialogs use the speed unit KiB/s. For consistency, using KiB/s in the adding torrent dialogs will be better.

PR #10617 touches the WebAPI, and it is closed. In this version the conversion finishes in the front end, the speed limit that will be transferred to the back end is still in Bytes/s.

Screenshots:
Before:
upload-before
url-before

After:
upload-after
url-after

@glassez glassez added the WebUI WebUI-related issues/changes label May 10, 2019
Chocobo1
Chocobo1 reviewed May 10, 2019
View reviewed changes
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits into the first one.

src/webui/www/private/download.html Show resolved Hide resolved
@jerrymakesjelly
Copy link
Contributor Author

Done

@Chocobo1 Chocobo1 added this to the 4.2.0 milestone May 11, 2019
@jerrymakesjelly
Change the speed unit from Bytes/s to KiB/s
4b9f0a8 
Updated the adding torrent dialogs in WebUI. Closes #10017.
@Chocobo1 Chocobo1 merged commit 6d73a7e into qbittorrent:master May 12, 2019
@Chocobo1
Copy link
Member

@jerrymakesjelly
Thank you!

@Chocobo1 Chocobo1 mentioned this pull request May 12, 2019
Merged
@Piccirello Piccirello mentioned this pull request Jun 3, 2019
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

WebUI suggestion: Change upload rate limits from Bytes/s to KiB/s
3 participants
@jerrymakesjelly @Chocobo1 @glassez