-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create 'data' subdirectory on Linux #11644
Conversation
At least you break existing installations, isn't it? |
Upgrade path could be as follows (semi pseudo-code):
|
EDIT: not a problem, see next post |
I agreed, |
FYI |
Confirmed, modified function returns path which is used everywhere, i.e. first time when folder must be created. |
Ok, upon a closer look, I can confirm that this patch should work as intended. That place is where, in fact, the directory is set to be created as such. For anyone interested, here is the full code path:
I would still recommend providing an upgrade path in this PR, as outlined above. |
I think the right way is to check if 'data' folder exists, then continue using it. That way no old installations brake, but newer ones and those where people moved it by hand will use cleaner path. |
@lbilli If you want this to get merged, you still need to provide an upgrade path, either |
@FranciscoPombal |
@lbilli Can you rebase and implement the suggested changes? The file has moved to |
Rebased and added a warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits into one.
Oh, yes. I guess the warning is just fine then. |
@lbilli |
Any reason to use on Linux the unusual path
instead of
?