Use tray icon from system theme only if option is set

[glassez]

Currently qBittorrent uses system tray icon from the Linux system theme regardless of whether the corresponding option is enabled. It looks inconsistent/incorrect to me and I believe this should be fixed.

[thalieht]

Now the theme's tray icon is never used even with "Use icons from system theme".

[glassez]

Now the theme's tray icon is never used even with "Use icons from system theme".

Are you sure your system theme contains appropriate icons? I tested it on Linux Mint 21 and there are none (at least in the theme I tested it with). When I copied qbittorrent-tray.svg in theme folder manually it is used by qBittorrent.

[thalieht]

Are you sure your system theme contains appropriate icons?

KDE's breeze theme has qBt tray icon and before this PR it was used unconditionally. Now qBt's own tray icons are used no matter what. I didn't touch any icons.

[glassez]

I tested it on Linux Mint 21 and there are none

In fact, I just checked if a file named qbittorrent-tray.* exists and it wasn't there. Could you check if there is one in KDE? I got an idea why it doesn't work.

[thalieht]

In fact, I just checked if a file named qbittorrent-tray.* exists and it wasn't there. Could you check if there is one in KDE?

Hmm there isn't but there are

/usr/share/icons/breeze-dark/apps/48/qbittorrent.svg
/usr/share/icons/breeze/apps/48/qbittorrent.svg

and according to #15931 (comment) they are used.

[glassez]

@thalieht
Could you try it now?

[thalieht]

Fixed 👍

/off topic
the theme's icon is still always used in qBt title bar

qBittorrent/src/gui/mainwindow.cpp

Line 136 in 8bcac1b

setWindowIcon(UIThemeManager::instance()->getIcon(u"qbittorrent"_qs));

[glassez]

the theme's icon is still always used in qBt title bar

You can trace UIThemeManager::getIcon() to make sure that it never uses the system theme icon if the option is not set (unlike the reverse case, when the built-in icon can be used as a fallback if the system one is missing). So it looks like a problem somewhere outside of qBittorrent.