Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Implement subcategories #18740

Merged
merged 7 commits into from
Apr 2, 2023
Merged

WebUI: Implement subcategories #18740

merged 7 commits into from
Apr 2, 2023

Conversation

Bartuzen
Copy link
Contributor

@Bartuzen Bartuzen commented Mar 21, 2023

  • Show subcategories in a tree view in WebUI
  • Add Add subcategory... context option to WebUI
  • Add use_subcategories property to maindata in WebAPI
  • Add Use subcategories preference to WebUI & WebAPI

Closes #12819

@glassez glassez changed the title WebUI: Add use subcategories option WebUI: Add "Use subcategories" option Mar 22, 2023
@glassez
Copy link
Member

glassez commented Mar 22, 2023

You've just allowed to switch core handling. But aren't categories expected to be shown in a tree view when "Use subcategories" is enabled (just like it's done in the qBittorrent Desktop GUI)?

@glassez glassez requested review from a team March 22, 2023 11:10
@glassez glassez added WebUI WebUI-related issues/changes WebAPI WebAPI-related issues/changes labels Mar 22, 2023
@Bartuzen
Copy link
Contributor Author

Bartuzen commented Mar 22, 2023

Actually, my aim was just implementing the option. But I decided to try implementing tree view. I'll either update this PR or create a new one when I'm done.

@glassez
Copy link
Member

glassez commented Mar 22, 2023

But I decided to try implementing tree view.

Perhaps you could consider how torrent content view is implemented.

Also add use_subcategories property to maindata
@Bartuzen Bartuzen marked this pull request as draft March 22, 2023 15:43
@Bartuzen Bartuzen changed the title WebUI: Add "Use subcategories" option WebUI: Show subcategories in a tree view Mar 22, 2023
@Bartuzen Bartuzen marked this pull request as ready for review March 22, 2023 20:05
@thalieht
Copy link
Contributor

GUI has context menu item "Add subcategory..." but i don't know if it's in scope of this PR.
Other than that i found no problems.

@Bartuzen Bartuzen changed the title WebUI: Show subcategories in a tree view WebUI: Implement subcategories Mar 22, 2023
thalieht
thalieht previously approved these changes Mar 23, 2023
@glassez glassez self-assigned this Mar 23, 2023
@glassez glassez added this to the 4.6.0 milestone Mar 23, 2023
thalieht
thalieht previously approved these changes Mar 23, 2023
@glassez
Copy link
Member

glassez commented Mar 28, 2023

It does not display torrents from subcategories when some parent category is selected.
Also the categories are non-collapsible unlike GUI, but this is not a blocking problem for me.

@thalieht
Copy link
Contributor

It does not display torrents from subcategories when some parent category is selected.

Maybe i'm misusing subcategories... but i wish that's how it worked in the GUI as well. For example a category "books" containing subcategories "history" and "math". I can't think of any reason i would want to see a list of those 2 subcategories together. Also because of that, if i care about filtering torrents by category, i can never assign them to a category that has subcategories.

@glassez
Copy link
Member

glassez commented Mar 29, 2023

For example a category "books" containing subcategories "history" and "math". I can't think of any reason i would want to see a list of those 2 subcategories together.

Any history book is a book as well as any math book is a book so when I select Books category I expect to see all the books despite their subcategories. That's how it was designed. This is what makes it different from the other mode (w/o subcategories), where "books" "books/history" and "books/math" are just 3 independent categories that are not related to each other in any way, except for the partial matching of the names.

@glassez glassez merged commit b55d4b1 into qbittorrent:master Apr 2, 2023
@glassez
Copy link
Member

glassez commented Apr 2, 2023

@Bartuzen
Thank you!

@sneakblade
Copy link

I think this is what fixed #18333, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable subcategories in nox
4 participants