Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make I2P session options configurable #19079

Merged
merged 2 commits into from Jun 6, 2023

Conversation

Vort
Copy link
Contributor

@Vort Vort commented Jun 3, 2023

Closes #18980.

Screenshot of new options:
image

@glassez glassez changed the title Make i2p session options configurable Make I2P session options configurable Jun 3, 2023
@glassez glassez requested a review from a team June 3, 2023 15:41
@glassez glassez self-assigned this Jun 3, 2023
@glassez glassez added GUI GUI-related issues/changes Core labels Jun 3, 2023
@glassez glassez added this to the 4.6.0 milestone Jun 3, 2023
@glassez
Copy link
Member

glassez commented Jun 3, 2023

@qbittorrent/bug-handlers
Please take a look at #18980 (comment) as well.

src/gui/advancedsettings.h Outdated Show resolved Hide resolved
@thalieht
Copy link
Contributor

thalieht commented Jun 3, 2023

Please take a look at #18980 (comment) as well.

  1. How exactly these options should be described in English. I'm not very confident with my English skills.

They're pretty technical terms but they come from libtorrent so I don't see how they can be improved. Maybe they make sense to those familiar with I2P.

  1. Where exactly they should be located. I positioned them after other spinbox-style options, but other possiblities also exists.

Current place is as good as any to me.

@Chocobo1
Copy link
Member

Chocobo1 commented Jun 4, 2023

Where exactly they should be located. I positioned them after other spinbox-style options, but other possiblities also exists.

Since those new settings are all related to I2P, I would put them at the bottom of the list.

I don't know if these options should be added also to WebUI. And I never used it and do not know how it works.

They should but it is not a hard requirement. If you are interested, you can take a look at #18806 to see how it is done.

@glassez
Copy link
Member

glassez commented Jun 4, 2023

I don't know if these options should be added also to WebUI. And I never used it and do not know how it works.

They should but it is not a hard requirement. If you are interested, you can take a look at #18806 to see how it is done.

AFAIK, no I2P related options is presented in WebUI yet so it is meaningless to add only these ones.

@glassez
Copy link
Member

glassez commented Jun 4, 2023

Since those new settings are all related to I2P, I would put them at the bottom of the list.

👍

@Vort
Copy link
Contributor Author

Vort commented Jun 4, 2023

Since those new settings are all related to I2P, I would put them at the bottom of the list.

Ok, I repositioned them after RequestQueueSize:
image

thalieht
thalieht previously approved these changes Jun 4, 2023
src/base/bittorrent/session.h Outdated Show resolved Hide resolved
src/base/bittorrent/sessionimpl.cpp Outdated Show resolved Hide resolved
src/base/bittorrent/sessionimpl.cpp Outdated Show resolved Hide resolved
src/base/bittorrent/sessionimpl.h Outdated Show resolved Hide resolved
src/base/bittorrent/sessionimpl.h Outdated Show resolved Hide resolved
glassez
glassez previously approved these changes Jun 5, 2023
@glassez glassez merged commit ff5d02b into qbittorrent:master Jun 6, 2023
17 of 18 checks passed
@glassez
Copy link
Member

glassez commented Jun 6, 2023

@Vort
Thank you!

@k4r4b3y
Copy link

k4r4b3y commented Sep 16, 2023

I don't know if these options should be added also to WebUI. And I never used it and do not know how it works.

They should but it is not a hard requirement. If you are interested, you can take a look at #18806 to see how it is done.

AFAIK, no I2P related options is presented in WebUI yet so it is meaningless to add only these ones.

@glassez when would the i2p options be presented in the WebUI for the headless qbittorrent-nox setups (release-4.6.0-rc2) ? Here's another user asking for the same thing in the forums: https://forum.qbittorrent.org/viewtopic.php?t=10995

@glassez
Copy link
Member

glassez commented Sep 16, 2023

@glassez when would the i2p options be presented in the WebUI for the headless qbittorrent-nox setups (release-4.6.0-rc2) ?

When someone contributes to adding it.

@k4r4b3y
Copy link

k4r4b3y commented Sep 16, 2023

@glassez when would the i2p options be presented in the WebUI for the headless qbittorrent-nox setups (release-4.6.0-rc2) ?

When someone contributes to adding it.

Whom can I bug on this? I reckon whoever added those to the qbittorrent GUI can add them to the webUI, too.

@k4r4b3y
Copy link

k4r4b3y commented Sep 16, 2023

@glassez can I enable those i2p proxy settings without the webUI but by editing the qBittorrent.conf file?

@glassez
Copy link
Member

glassez commented Sep 16, 2023

@glassez can I enable those i2p proxy settings without the webUI but by editing the qBittorrent.conf file?

Yes.

@k4r4b3y
Copy link

k4r4b3y commented Sep 16, 2023

@glassez can I enable those i2p proxy settings without the webUI but by editing the qBittorrent.conf file?

Yes.

How may I do that? What should I add to the config file?

@thalieht
Copy link
Contributor

What should I add to the config file?

Dunno if these are the defaults:

[BitTorrent]
Session\I2P\Address=127.0.0.1
Session\I2P\Enabled=false
Session\I2P\InboundLength=3
Session\I2P\InboundQuantity=3
Session\I2P\MixedMode=true
Session\I2P\OutboundLength=3
Session\I2P\OutboundQuantity=3
Session\I2P\Port=7656

@k4r4b3y
Copy link

k4r4b3y commented Sep 17, 2023

@thalieht these worked, thanks. Here are the things I added by using your example:

Session\I2P\Address=127.0.0.1
Session\I2P\Enabled=true
Session\I2P\InboundLength=2
Session\I2P\InboundQuantity=10
Session\I2P\MixedMode=false
Session\I2P\OutboundLength=2
Session\I2P\OutboundQuantity=10
Session\I2P\Port=7656

I have reduced the inbound/outbound tunnel lengths and have increased the tunnel quantities in order to get faster downloads.

@Vort Vort mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2P: make session options configurable
5 participants