-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I2P support #16257
Comments
See #2682 |
Last comment was from 2018 by arvidn. It is 2022 now. New features in I2P have been added and some changes have been done on their side, I hope that, now it will be easier to integrate it into qBittorrent & will be successful this time. In any case, eagerly waiting for this feature request to be completed. |
+1 for this feature. It also can help establish connection between passive clients. |
Im not a developer, but maybe it must be first implemented in libtorrent. I suppose that libtorrent cant use domain name instead IPv4/IPv6 adressess. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Libtorrent team is actively trying to solve i2p issues. arvidn/libtorrent#7272 qBittorent team should keep tabs on it, so that they can implement changes as early as possible. Thanks. |
Most of the issues related to i2p have been fixed in libtorrent with this commit: arvidn/libtorrent@94ed94e |
I have never used I2P. Could someone explain with an example of some easily reproducible scenario how it is supposed to work with qBittorrent? So that I can figure out what we have to do. |
It is not supported by the qBittorrent. That's what this whole thread is about. |
So I'm trying to figure out what needs to be done to implement its support. |
First of all, user installs either Java I2P software or i2pd. |
How can I test it? Should they be some special torrents (from some specific trackers)? |
With this magnet for example: |
This is a code snippet related to that (not C++ deluge is written in python): core/preferencesmanager.py
Essentially lt.proxy_type_t.i2p_proxy is the python version of lt::settings_pack::i2p_proxy Hope it helps. |
Thanks. The code is not a problem. I was more interested in what it was from a user perspective (I remind you that I have never used I2P myself). So it turns out it's just another type of proxy, right? Then it shouldn't be a problem to add it soon. It would be very helpful if one of the interested persons could test the build from the corresponding PR when it is published. |
SAM protocol is similar to proxy protocols.
I don't know what are my capabilities regarding building binaries. |
As side note, since i2p is for anonimity and privacy maybe could be useful to force proxy use when in i2p mode to prevent leaking. Extra options for those that aren't concerned about privacy could be using "i2p-mixed" mode of libtorrent so that will be possible to use both i2p and clesrbet peers. |
@jiigen I suspect that "force use" mode is default now. And I doubt that mixed mode work at all. Did you tried it? |
To try mixed mode a torrent with both i2p and clearnet seeds would be needed, and so far I hadn't the chance to test. In deluge is possible to set mixed mode through a plugin: |
@jiigen link to your commit is incorrect - it have 1 extra character. |
@Vort thanks, now I've corrected it |
So it retrieve peers and the download starts that's a good starting point :-) ! Which setting did you use in the preferences?
This makes me think that the problem could be somewhere in libtorrent maybe. |
Yes, this is good.
This is what I used:
But client_test shows peer list correctly! |
So it's something in both client we didn't find so far. I can't do reliable tests atm cuz I'm building in quickly built docker environment but I got same results and settings didn't get saved for me too. Anyway I think that now @glassez has something to start with. |
With this change proxy type is loaded correctly. |
@jiigen |
I've done both...just in case :-) |
@Vort Maybe I've found what causes the issue in deluge : |
@Vort I was right, with some little modifications I managed to make deluge show the i2p peers correctly: This confirms definitively that the issue is with the clients (Deluge and qBittorrent) not with libtorrent. Too bad I wasn't able to do the same in qBittorrent but guess there must be a similar issue. |
Which application is shown in this screenshot? |
BiglyBT
Almost. It is base32 representation of hash of destination: Destination is I2P equivalent of IP address. |
I have installed the unstable version of qbittorrent from this repo: https://launchpad.net/~qbittorrent-team/+archive/ubuntu/qbittorrent-unstable on ubuntu. On the desktop version there is the i2p option, but the nox/web version is missing i2p |
@Bkeinn, you can try to edit configuration file manually for Web version. |
@Vort I never used qbittorrent before, so I am not quite sure what I should be looking for. ~/.config/qbittorrent/qBittorrent.conf does not include any mention of i2p |
@Bkeinn I thought it should. But if not, can be added. |
Suggestion
I would like to suggest I2P support for qBittorrent in the form of a plugin or inbuilt facility.
Use case
Use case is -
Screenshots are attached, to further explain my points.
The text was updated successfully, but these errors were encountered: