I2P support #16257

absolutep · 2022-01-24T16:25:42Z

Suggestion

I would like to suggest I2P support for qBittorrent in the form of a plugin or inbuilt facility.

Use case

Use case is -

Anonymous torrenting, since I2P network is a closed system the IP addresses do not get leaked via torrenting swarm.

It will help people facing a port connectivity issue or any other connectivity issue as peers from I2P network will help in ul/dl of a file.

Screenshots are attached, to further explain my points.

kurnevsky · 2022-02-03T15:41:57Z

See #2682

absolutep · 2022-02-12T12:36:24Z

Last comment was from 2018 by arvidn. It is 2022 now.

New features in I2P have been added and some changes have been done on their side, I hope that, now it will be easier to integrate it into qBittorrent & will be successful this time.

In any case, eagerly waiting for this feature request to be completed.

Griss168 · 2022-03-05T20:33:26Z

+1 for this feature. It also can help establish connection between passive clients.

absolutep · 2022-03-06T09:01:01Z

+1 for this feature. It also can help establish connection between passive clients.

exactly.

As can be seen from the below screenshot.

A seeder/leecher can connect to the following simultaneously

trackers
DHT, PEX
I2P DHT

Griss168 · 2022-03-06T09:44:53Z

Im not a developer, but maybe it must be first implemented in libtorrent. I suppose that libtorrent cant use domain name instead IPv4/IPv6 adressess.

absolutep · 2023-01-17T11:19:54Z

Libtorrent team is actively trying to solve i2p issues. arvidn/libtorrent#7272

qBittorent team should keep tabs on it, so that they can implement changes as early as possible. Thanks.

jiigen · 2023-01-23T07:47:39Z

Most of the issues related to i2p have been fixed in libtorrent with this commit: arvidn/libtorrent@94ed94e
I've personally tested the fixed library with deluge-torrent and apart some minor issues it seems to work:
https://dev.deluge-torrent.org/ticket/3583
So I hope that qbittorrent will implement it so that with more testers other issues and/or new features can be fixed/added.
Thanks in advance.

glassez · 2023-01-23T11:21:43Z

I have never used I2P. Could someone explain with an example of some easily reproducible scenario how it is supposed to work with qBittorrent? So that I can figure out what we have to do.

Griss168 · 2023-01-23T11:29:16Z

I have never used I2P. Could someone explain with an example of some easily reproducible scenario how it is supposed to work with qBittorrent? So that I can figure out what we have to do.

It is not supported by the qBittorrent. That's what this whole thread is about.

glassez · 2023-01-23T11:32:58Z

I have never used I2P. Could someone explain with an example of some easily reproducible scenario how it is supposed to work with qBittorrent? So that I can figure out what we have to do.

It is not supported by the qBittorrent. That's what this whole thread is about.

So I'm trying to figure out what needs to be done to implement its support.

Vort · 2023-01-23T11:36:04Z

I have never used I2P. Could someone explain with an example of some easily reproducible scenario how it is supposed to work with qBittorrent? So that I can figure out what we have to do.

First of all, user installs either Java I2P software or i2pd.
Then user enables SAM protocol either in web console (I2P) or in config (i2pd).
Then user should specify SAM address and port (usually 127.0.0.1:7656) somewhere in qBittorrent UI (proxy settings maybe?).
qBittorrent should translate it to lt::settings_pack::i2p_port and lt::settings_pack::i2p_hostname and set lt::settings_pack::proxy_type to lt::settings_pack::i2p_proxy.
Now torrents can be downloaded via i2p network.

glassez · 2023-01-23T11:46:01Z

Now torrents can be downloaded via i2p network.

How can I test it? Should they be some special torrents (from some specific trackers)?

Vort · 2023-01-23T11:46:32Z

How can I test it? Should they be some special torrents (from some specific trackers)?

With this magnet for example:
magnet:?xt=urn:btih:cb18974db461c640c0d938710203bb263a746694&dn=I2P%2B+Universal+Installer+2.0.0%2B&tr=http://tracker2.postman.i2p/announce.php

jiigen · 2023-01-23T19:45:07Z

These are the settings that Deluge exposes to the user:

which essentially enable the settings in libtorrent mentioned by @Vort (plus some extra ones).

jiigen · 2023-01-23T20:10:54Z

This is a code snippet related to that (not C++ deluge is written in python):

core/preferencesmanager.py

def _on_set_proxy(self, key, value):
        # Initialise with type none and blank hostnames.
        proxy_settings = {
            'proxy_type': lt.proxy_type_t.none,
            'i2p_hostname': '',
            'proxy_hostname': '',
            'proxy_hostnames': value['proxy_hostnames'],
            'proxy_peer_connections': value['proxy_peer_connections'],
            'proxy_tracker_connections': value['proxy_tracker_connections'],
            'force_proxy': value['force_proxy'],
            'anonymous_mode': value['anonymous_mode'],
        }

        if value['type'] == lt.proxy_type_t.i2p_proxy:
            proxy_settings.update(
                {
                    'proxy_type': lt.proxy_type_t.i2p_proxy,
                    'i2p_hostname': value['hostname'],
                    'i2p_port': value['port'],
                }
            )
        elif value['type'] != lt.proxy_type_t.none:
            proxy_settings.update(
                {
                    'proxy_type': value['type'],
                    'proxy_hostname': value['hostname'],
                    'proxy_port': value['port'],
                    'proxy_username': value['username'],
                    'proxy_password': value['password'],
                }
            )

        self.core.apply_session_settings(proxy_settings)

Essentially lt.proxy_type_t.i2p_proxy is the python version of lt::settings_pack::i2p_proxy

Hope it helps.

glassez · 2023-01-24T05:45:12Z

This is a code snippet related to that (not C++ deluge is written in python):

Thanks. The code is not a problem. I was more interested in what it was from a user perspective (I remind you that I have never used I2P myself). So it turns out it's just another type of proxy, right? Then it shouldn't be a problem to add it soon. It would be very helpful if one of the interested persons could test the build from the corresponding PR when it is published.

jiigen · 2023-01-24T07:14:18Z

I've tried to modify some code to add i2p support but for some library problems (outdated qt5 on my system) couldn't try a build: cd7b9ea so I didn't go ahead.

Anyway I think there are more people interested on this feature sure @Vort and me (when I update my system) will be glad to test.

Vort · 2023-01-24T08:13:57Z

So it turns out it's just another type of proxy, right?

SAM protocol is similar to proxy protocols.
It allows to route all communications with I2P network through single IP:port.
However, because I2P network have some unique properties, I2P support needs to be deeply integrated into libtorrent code.
For example, I2P network do not use IP addresses. It means that both library and client should be tuned accordingly.
Also SAM protocol allows to make tradeoffs between security and speed. For now default value is used, so it is enough to make SAM support to look just like another proxy protocol, but in future it is better to allow user tweaking such parameters.

It would be very helpful if one of the interested persons could test the build from the corresponding PR when it is published.

I don't know what are my capabilities regarding building binaries.
But in case Windows 7 compatible binaries will be available, then no problems.

jiigen · 2023-01-24T08:18:59Z

As side note, since i2p is for anonimity and privacy maybe could be useful to force proxy use when in i2p mode to prevent leaking. Extra options for those that aren't concerned about privacy could be using "i2p-mixed" mode of libtorrent so that will be possible to use both i2p and clesrbet peers.

Vort · 2023-01-24T08:20:47Z

@jiigen I suspect that "force use" mode is default now. And I doubt that mixed mode work at all. Did you tried it?
It may be needed to think about disabling DHT however. Theoretically, it should work through I2P, but looks like support is not implemented correctly yet.

jiigen · 2023-01-24T08:25:09Z

To try mixed mode a torrent with both i2p and clearnet seeds would be needed, and so far I hadn't the chance to test. In deluge is possible to set mixed mode through a plugin:
https://github.com/ratanakvlun/deluge-ltconfig

Vort · 2023-01-24T09:41:47Z

I've tried to modify some code to add i2p support

@jiigen link to your commit is incorrect - it have 1 extra character.

jiigen · 2023-01-24T11:51:19Z

@Vort thanks, now I've corrected it

Vort · 2023-01-24T18:39:56Z

@jiigen your commit was almost right. I fixed it a little: 585dbeb
And here are the results:

Looks like the same problem as with Deluge: peer list shows wrong information.

jiigen · 2023-01-24T20:02:56Z

@jiigen your commit was almost right. I fixed it a little: 585dbeb And here are the results:

So it retrieve peers and the download starts that's a good starting point :-) ! Which setting did you use in the preferences?

Looks like the same problem as with Deluge: peer list shows wrong information.

This makes me think that the problem could be somewhere in libtorrent maybe.

Vort · 2023-01-24T20:28:32Z

So it retrieve peers and the download starts that's a good starting point :-) !

Yes, this is good.

Which setting did you use in the preferences?

This is what I used:

For some reason type option is not saved for me and client crashes at exit.
But it may be because I changed some build parameter - build was failing otherwise.

This makes me think that the problem could be somewhere in libtorrent maybe.

But client_test shows peer list correctly!

jiigen · 2023-01-24T20:44:09Z

But client_test shows peer list correctly!

So it's something in both client we didn't find so far. I can't do reliable tests atm cuz I'm building in quickly built docker environment but I got same results and settings didn't get saved for me too. Anyway I think that now @glassez has something to start with.

jiigen · 2023-01-25T08:44:59Z

For some reason type option is not saved for me.

@Vort maybe I've fixed this: 62f422b

Vort · 2023-01-25T09:02:17Z

maybe I've fixed this: 62f422b

With this change proxy type is loaded correctly.

glassez · 2023-01-26T04:59:13Z

@jiigen
Would you mind to create Pull Request?
Or if you want me to continue this work, you could create Pull Request to i2p branch of my fork.

jiigen · 2023-01-26T17:02:21Z

@jiigen Would you mind to create Pull Request? Or if you want me to continue this work, you could create Pull Request to i2p branch of my fork.

I've done both...just in case :-)

jiigen · 2023-01-27T19:09:37Z

@glassez I did an error pushing the wrong mod, fixed it now:
b54903f
Sorry

jiigen · 2023-02-10T16:27:04Z

But client_test shows peer list correctly!

@Vort Maybe I've found what causes the issue in deluge :
https://github.com/deluge-torrent/deluge/blob/2a945de0695ba0a5bf2d928ce4bd541d0f5cf2a8/deluge/ui/gtk3/peers_tab.py#L257
Peers are listed using their IP as key and removing duplicates so since every i2p peer has 0.0.0.0 as IP they get all discarded apart one. Maybe in qBittorrent there's something similar?

jiigen · 2023-02-14T07:09:18Z

@Vort I was right, with some little modifications I managed to make deluge show the i2p peers correctly:

This confirms definitively that the issue is with the clients (Deluge and qBittorrent) not with libtorrent. Too bad I wasn't able to do the same in qBittorrent but guess there must be a similar issue.
This commit jiigen/libtorrent@02884d3 makes the python code more clean too, without it was still possible to distinguish i2p peers comparing ip with 0.0.0.0 but thought that would have been better to have that flag available.

glassez · 2023-03-18T10:45:52Z

Which application is shown in this screenshot?
Excuse my ignorance, are these identifiers called "destinations" according to I2P?
Unfortunately, I did not find any identifier other than IP/port in the information provided by libtorrent (however, I found that the internal classes contain "destination" property for I2P peers).

glassez · 2023-03-18T10:52:27Z

arvidn/libtorrent#7346

Vort · 2023-03-18T11:02:33Z

Which application is shown in this screenshot?

BiglyBT

are these identifiers called "destinations" according to I2P?

Almost. It is base32 representation of hash of destination:
https://geti2p.net/en/docs/naming#base32

Destination is I2P equivalent of IP address.

PR #18717. Closes #16257.

Bkeinn · 2023-10-05T14:57:59Z

I have installed the unstable version of qbittorrent from this repo: https://launchpad.net/~qbittorrent-team/+archive/ubuntu/qbittorrent-unstable on ubuntu.

On the desktop version there is the i2p option, but the nox/web version is missing i2p

Vort · 2023-10-05T18:48:51Z

@Bkeinn, you can try to edit configuration file manually for Web version.

Bkeinn · 2023-10-06T19:25:21Z

@Vort I never used qbittorrent before, so I am not quite sure what I should be looking for. ~/.config/qbittorrent/qBittorrent.conf does not include any mention of i2p

Vort · 2023-10-06T20:02:31Z

@Bkeinn I thought it should. But if not, can be added.
Look at these two messages: #19079 (comment) #19079 (comment).

absolutep added the Feature request label Jan 24, 2022

absolutep mentioned this issue Apr 3, 2022

I2P support arvidn/libtorrent#2530

Closed

This comment was marked as spam.

Sign in to view

thalieht changed the title ~~I2P support - feature request~~ I2P support Aug 9, 2022

This comment was marked as spam.

Sign in to view

glassez self-assigned this Jan 24, 2023

jiigen mentioned this issue Jan 26, 2023

Initial I2P support #18462

Closed

glassez mentioned this issue Mar 17, 2023

Add I2P support #18717

Merged

glassez closed this as completed in #18717 Mar 21, 2023

glassez added a commit that referenced this issue Mar 21, 2023

Add (experimental) I2P support

cdded6c

PR #18717. Closes #16257.

I2P support #16257

I2P support #16257

Comments

absolutep commented Jan 24, 2022 • edited Loading

Suggestion

Use case

kurnevsky commented Feb 3, 2022

absolutep commented Feb 12, 2022

Griss168 commented Mar 5, 2022

absolutep commented Mar 6, 2022 • edited Loading

Griss168 commented Mar 6, 2022

This comment was marked as spam.

This comment was marked as spam.

absolutep commented Jan 17, 2023

jiigen commented Jan 23, 2023

glassez commented Jan 23, 2023

Griss168 commented Jan 23, 2023

glassez commented Jan 23, 2023

Vort commented Jan 23, 2023 • edited Loading

glassez commented Jan 23, 2023

Vort commented Jan 23, 2023

jiigen commented Jan 23, 2023 • edited Loading

jiigen commented Jan 23, 2023

glassez commented Jan 24, 2023

jiigen commented Jan 24, 2023 • edited Loading

Vort commented Jan 24, 2023

jiigen commented Jan 24, 2023

Vort commented Jan 24, 2023 • edited Loading

jiigen commented Jan 24, 2023

Vort commented Jan 24, 2023

jiigen commented Jan 24, 2023

Vort commented Jan 24, 2023

jiigen commented Jan 24, 2023 • edited Loading

Vort commented Jan 24, 2023

jiigen commented Jan 24, 2023

jiigen commented Jan 25, 2023 • edited Loading

Vort commented Jan 25, 2023

glassez commented Jan 26, 2023

jiigen commented Jan 26, 2023

jiigen commented Jan 27, 2023

jiigen commented Feb 10, 2023

jiigen commented Feb 14, 2023 • edited Loading

glassez commented Mar 18, 2023

glassez commented Mar 18, 2023

Vort commented Mar 18, 2023

Bkeinn commented Oct 5, 2023

Vort commented Oct 5, 2023

Bkeinn commented Oct 6, 2023

Vort commented Oct 6, 2023

absolutep commented Jan 24, 2022 •

edited

Loading

absolutep commented Mar 6, 2022 •

edited

Loading

Vort commented Jan 23, 2023 •

edited

Loading

jiigen commented Jan 23, 2023 •

edited

Loading

jiigen commented Jan 24, 2023 •

edited

Loading

Vort commented Jan 24, 2023 •

edited

Loading

jiigen commented Jan 24, 2023 •

edited

Loading

jiigen commented Jan 25, 2023 •

edited

Loading

jiigen commented Feb 14, 2023 •

edited

Loading