Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: API documentation file #19198

Closed

Conversation

sledgehammer999
Copy link
Member

This is taken from the wiki file named WebUI API (qBittorrent 4.1) based on https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1)/00539df6f232ef8cda329097513ab67696bbf52f

Github offers very rudimentary controls for wiki edits. It is either "leave it open for every github user" or "restrict it to user with push access to the repo".

For sometime now it is restricted to users with push access.
However, the WebAPI docs have become stale because members have stopped working on them. (members became inactive due to personal reasons).

I can see 2 available solutions:
A. Make the wiki open again. The drawback is that we might get malicious editing again.
B. Move the API docs as a file in the repo and link to it from the wiki. Like it is done with CODING_GUIDELINES.md. The drawback is that anyone wishing to edit the file will have to make a PR, get it reviewed and merged.

I don't know which of the solutions is best. I implement here solution B.
A discussion can be made here for solution A or another one.

@sledgehammer999 sledgehammer999 added Documentation WebAPI WebAPI-related issues/changes labels Jun 18, 2023
@glassez glassez requested review from a team June 18, 2023 19:00
@Chocobo1
Copy link
Member

Chocobo1 commented Jun 19, 2023

Or maybe we can move the wiki to its own repo and give our team members write access to it (and no need for formal approvals in this wiki repo)? So every changes will be at least skimmed through by someone and no malicious content would get in. And no need for formal reviews/suggestions, just accept the changes if they are decent.

However, the WebAPI docs have become stale because members have stopped working on them. (members became inactive due to personal reasons).

I think it's not only WebAPI docs but all wiki content has stalled hence the suggestion of a wiki repo.

@sledgehammer999
Copy link
Member Author

I think it's not only WebAPI docs but all wiki content has stalled hence the suggestion of a wiki repo.

In the repo only the same people that can edit the Wiki now will be able to contribute.
Unless, there are some of those people willing to take care of PRs too.

@github-actions
Copy link

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

@github-actions github-actions bot added the Stale label Sep 17, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Sep 17, 2023

@luzpaz
Copy link
Contributor

luzpaz commented Sep 17, 2023

Screenshot_20230917_082037

Also it looks like the API is missing hte latest torrent creation functionality.

Edit: FWIW I think API documentation should have tight control and therefore migrated to github wiki.

@github-actions github-actions bot removed the Stale label Sep 18, 2023
Copy link

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

@github-actions github-actions bot added the Stale label Nov 17, 2023
Copy link

This PR was closed because it has been stalled for some time with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Stale WebAPI WebAPI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants