WebUI: Fix duplicate scrollbar on Transfer List #19779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overlay scrollbars introduced in Firefox 100 take up no space, breaking the existing overflow detection. Add an extra check for scrollHeight != clientHeight which is able to detect an overflow independent of scrollbar style.
glassez
changed the title
Chocobo1
approved these changes
Oct 27, 2023
glassez
approved these changes
Oct 27, 2023
|
@AgentConDier |
|
@Chocobo1 |
|
Yes. |
This was referenced Oct 31, 2023
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Nov 8, 2023
The overlay scrollbars introduced in Firefox 100 take up no space, breaking the existing overflow detection. Add an extra check for `scrollHeight != clientHeight` which is able to detect an overflow independent of scrollbar style. PR qbittorrent#19779. --------- Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlay scrollbars introduced in Firefox 100 take up no space, breaking the existing overflow detection. This may result in a second, defunct vertical scrollbar inside the Transfer List Panel with a travel of only 1px.
Add an extra check for scrollHeight != clientHeight which is able to detect an overflow independent of scrollbar style (MDN).
Before:
After:
