Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport changes to v4.6.x branch #19751

Merged
merged 24 commits into from Nov 13, 2023
Merged

Backport changes to v4.6.x branch #19751

merged 24 commits into from Nov 13, 2023

Conversation

glassez
Copy link
Member

@glassez glassez commented Oct 23, 2023 •
edited

@glassez glassez added this to the 4.6.1 milestone Oct 23, 2023
@glassez glassez mentioned this pull request Oct 23, 2023
Merged
@Chocobo1

This comment was marked as resolved.

Sign in to view
@glassez

This comment was marked as resolved.

Sign in to view
@Chocobo1

This comment was marked as resolved.

Sign in to view
@rmartin16 rmartin16 mentioned this pull request Nov 2, 2023
Merged
thalieht and others added 19 commits November 8, 2023 08:34
@thalieht @glassez
Add I2P settings to WebUI
7b73d3f 
PR qbittorrent#19700.
@glassez
CI: Use dynamic MSVC run-time library
dc31e82 
Otherwise, there is a conflict of run-time libraries used (since Qt DLLs are still use dynamic MSVCRT) that leads to strange errors.

PR qbittorrent#19718.
Closes qbittorrent#19701.
@Chocobo1 @glassez
Combine CSS properties
4b56bdd 
PR qbittorrent#19730.
@glassez
Prevent crash due to race condition when adding magnet link
42d7465 
PR qbittorrent#19792.
Closes qbittorrent#19780.
Closes qbittorrent#19790.
@glassez
Fix Enter key behavior when add new torrent
a1317e2 
PR qbittorrent#19787.
Closes qbittorrent#19760.
@AgentConDier @Chocobo1 @glassez
WebUI: Fix duplicate scrollbar on Transfer List
a396e0d 
The overlay scrollbars introduced in Firefox 100 take up no space,
breaking the existing overflow detection.
Add an extra check for `scrollHeight != clientHeight` which is able to
detect an overflow independent of scrollbar style.

PR qbittorrent#19779.

---------

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
@Chocobo1 @glassez
Remove "Physical memory (RAM) usage limit" option on macOS qbittorren…
bb6d69f 
…t#19805

This has no effect on macOS.
https://stackoverflow.com/questions/3274385/how-to-limit-memory-of-a-os-x-program-ulimit-v-neither-m-are-working

Closes qbittorrent#18656.
PR  qbittorrent#19805.
@Chocobo1 @glassez
GHA CI: don't override cmake default CXXFLAGS
31e0ab2
@iomezk @glassez
Add missing main window icon
3c0747f 
PR qbittorrent#19815.

---
Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
@glassez
Don't forget to delete TorrentContentAdaptor instance
d5c0c09 
PR qbittorrent#19825.
Closes qbittorrent#19816.
@vit9696 @glassez
Fix .torrent file upload on iPadOS
ee853d8 
Mobile Safari on iOS does report `ios` platform, but iPadOS reports `mac`
instead. It is common sense to check for touch points when this happens
to differentiate Mac and iPad.

PR qbittorrent#19822.
Closes qbittorrent#19057.

---------

Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
@glassez
Update size of selected files when selection is changed
b284d40 
PR qbittorrent#19827.
Closes qbittorrent#19818.
@glassez
Correctly handle changing save path of torrent w/o metadata
a14b50e 
PR qbittorrent#19829.
Closes qbittorrent#19824.
@glassez
Allow to request torrents count via WebAPI
54dffa1 
PR qbittorrent#19831.
Closes qbittorrent#19731.
@Bartuzen @glassez
WebUI: Fix incorrect subcategory sorting
837d39d 
PR qbittorrent#19833.
Closes qbittorrent#19756.
@glassez
Always use QStyledItemDelegate as base of delegate classes
903173b 
PR qbittorrent#19340.
@xavier2k6 @glassez
Use appropriate icon for "moving" torrents in transfer list
c2dd53c 
PR qbittorrent#19821.
@Chocobo1 @glassez
Remove column span
c7dfc1d 
The property widget already has scroll bars and thus we don't need this span.

Closes qbittorrent#15000.
PR qbittorrent#19404.
@itsnotv @glassez
WebUI: Remove extra ')' in QBT_TR macro
2c2252d 
PR qbittorrent#19894.
@glassez glassez requested a review from a team November 10, 2023 06:13
@sledgehammer999

This comment was marked as resolved.

Sign in to view
@glassez

This comment was marked as resolved.

Sign in to view
@glassez

This comment was marked as resolved.

Sign in to view
@glassez
Copy link
Member Author

glassez commented Nov 12, 2023

@sledgehammer999
#19919 improves #19831 so they should be merged into single entry in the changelog.

@sledgehammer999

This comment was marked as resolved.

Sign in to view
@glassez

This comment was marked as resolved.

Sign in to view
@glassez
Improve free disk space checking for WebAPI
b824889 
Use single free disk space checker instance for all the web sessions.

PR qbittorrent#19855.
Closes qbittorrent#19732.
@glassez glassez merged commit 267d504 into qbittorrent:v4_6_x Nov 13, 2023
18 checks passed
@glassez glassez mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledgehammer999 sledgehammer999 sledgehammer999 approved these changes

Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@glassez @Chocobo1 @sledgehammer999 @thalieht @AgentConDier @iomezk @vit9696 @Bartuzen @xavier2k6 @itsnotv