Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash due to race condition when adding magnet link #19792

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Prevent crash due to race condition when adding magnet link #19792

merged 1 commit into from
Oct 28, 2023

Conversation

glassez
Copy link
Member

@glassez glassez commented Oct 26, 2023

Closes #19780.
Closes #19790.

@glassez glassez added the Core label Oct 26, 2023
@glassez glassez added this to the 4.6.1 milestone Oct 26, 2023
@glassez glassez requested a review from a team October 26, 2023 15:46
@glassez
Copy link
Member Author

glassez commented Oct 26, 2023

Closes #19780. Closes #19790.

I'm not sure about these issues. But the bug being fixed can cause exactly the same crash as the ones mentioned above.

@glassez glassez merged commit 12674d2 into qbittorrent:master Oct 28, 2023
13 checks passed
@glassez glassez deleted the cancel-metadata branch October 28, 2023 07:41
This was referenced Oct 28, 2023
Merged
Open
glassez added a commit to glassez/qBittorrent that referenced this pull request Nov 8, 2023
@glassez
Prevent crash due to race condition when adding magnet link
42d7465 
PR qbittorrent#19792.
Closes qbittorrent#19780.
Closes qbittorrent#19790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@xavier2k6 xavier2k6 xavier2k6 approved these changes

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

Crashes when trying to open magnet link Latest version threw a few crash report out :(
3 participants
@glassez @Chocobo1 @xavier2k6