Add missing main window icon #19815
Merged
Add missing main window icon #19815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would add file alias in Below the following line: qBittorrent/src/icons/icons.qrc Line 329 in ee9390f |
glassez
added
OS: Linux
glassez
changed the title
glassez
changed the title
|
Adding an alias is safer and solves the issue as expected. |
glassez
approved these changes
Oct 29, 2023
xavier2k6
approved these changes
Oct 30, 2023
|
@iomezk |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Nov 8, 2023
PR qbittorrent#19815. --- Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window icon isn't showing if "Use icons from system theme" setting is disabled.
This is how it looks in Lubuntu 22.04 / 23.10 for qBittorrent from sources/repo/AppImage:
The proposed patch uses "qbittorrent-tray" icon because there is no "qbittorrent" icon in the UI Theme.Perhaps a better solution is possible.