Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appropriate icon for "moving" torrents in transfer list #19821

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Use appropriate icon for "moving" torrents in transfer list #19821

merged 1 commit into from
Nov 4, 2023

Conversation

xavier2k6
Copy link
Member

@xavier2k6 xavier2k6 commented Oct 29, 2023 •
edited

Before this PR, "checking/moving" shared the same icon in transferlist.

GUI: Before

Screenshot 2023-10-29 123634

GUI - After:

Screenshot 2023-10-29 125925

WebUI - Before:

Screenshot 2023-10-29 123737

WebUI - After:

Screenshot 2023-10-29 130010

@xavier2k6 xavier2k6 added WebUI WebUI-related issues/changes Look and feel Affect UI "Look and feel" only without changing the logic GUI GUI-related issues/changes labels Oct 29, 2023
@xavier2k6 xavier2k6 requested a review from a team October 29, 2023 13:10
@xavier2k6
Copy link
Member Author

I plan to add a "moving filter" to side panel for "WebUI" in a follow-up PR.

@glassez glassez changed the title GUI/WebUI: Segregate/Display "moving" torrent state correctly in transferlist Segregate/Display "moving" torrent state correctly in transferlist Oct 29, 2023
@glassez glassez changed the title Segregate/Display "moving" torrent state correctly in transferlist Segregate/Display "moving" torrent state correctly in transfer list Oct 29, 2023
@glassez glassez added this to the 4.6.1 milestone Nov 3, 2023
@glassez
Copy link
Member

glassez commented Nov 3, 2023

I believe there is no problem to add it in v4.6.x branch, right?

@trim21
Copy link
Contributor

trim21 commented Nov 3, 2023

I believe there is no problem to add it in v4.6.x branch, right?

yes

@glassez glassez changed the title Segregate/Display "moving" torrent state correctly in transfer list Use appropriate icon for "moving" torrents in transfer list Nov 3, 2023
@xavier2k6
Copy link
Member Author

I believe there is no problem to add it in v4.6.x branch, right?

Don't see why not....

@glassez glassez merged commit 0186f44 into qbittorrent:master Nov 4, 2023
13 checks passed
@glassez glassez mentioned this pull request Nov 4, 2023
Merged
glassez pushed a commit to glassez/qBittorrent that referenced this pull request Nov 8, 2023
@xavier2k6 @glassez
Use appropriate icon for "moving" torrents in transfer list
c2dd53c 
PR qbittorrent#19821.
@vincejv vincejv mentioned this pull request Nov 24, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

@thalieht thalieht thalieht approved these changes

Assignees
No one assigned
Labels
GUI GUI-related issues/changes Look and feel Affect UI "Look and feel" only without changing the logic WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xavier2k6 @glassez @trim21 @thalieht