Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .torrent file upload on iPadOS #19822

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix .torrent file upload on iPadOS #19822

merged 2 commits into from
Nov 1, 2023

Conversation

vit9696
Copy link
Contributor

@vit9696 vit9696 commented Oct 29, 2023

Mobile Safari on iOS does report ios platform, but iPadOS reports mac instead. It is common sense to check for touch points when this happens to differentiate Mac and iPad.

Closes #19057.

Mobile Safari on iOS does report `ios` platform, but iPadOS reports `mac`
instead. It is common sense to check for touch points when this happens
to differentiate Mac and iPad.

closes #19057
@vit9696
Copy link
Contributor Author

vit9696 commented Oct 29, 2023

Tested working on iPadOS 16.7.2. Reference issue description in https://stackoverflow.com/questions/57765958/how-to-detect-ipad-and-ipad-os-version-in-ios-13-and-up.

@glassez glassez changed the title Fix .torrent upload on iPadOS Fix .torrent file upload on iPadOS Oct 29, 2023
@glassez glassez requested a review from a team October 29, 2023 14:40
@glassez glassez added OS: macOS Issues specific to macOS WebUI WebUI-related issues/changes labels Oct 29, 2023
@glassez glassez added this to the 4.6.1 milestone Oct 29, 2023
Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
@glassez glassez requested a review from a team October 31, 2023 07:19
@glassez glassez merged commit e42d3f3 into qbittorrent:master Nov 1, 2023
13 checks passed
@glassez
Copy link
Member

glassez commented Nov 1, 2023

@vit9696
Thank you!

glassez added a commit to glassez/qBittorrent that referenced this pull request Nov 8, 2023
Mobile Safari on iOS does report `ios` platform, but iPadOS reports `mac`
instead. It is common sense to check for touch points when this happens
to differentiate Mac and iPad.

PR qbittorrent#19822.
Closes qbittorrent#19057.

---------

Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: macOS Issues specific to macOS WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to select *.torrent files fromWebUI on iOS/iPadOS etc..
3 participants