Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Remove extra ')' in QBT_TR macro #19894

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

itsnotv
Copy link
Contributor

@itsnotv itsnotv commented Nov 6, 2023

Removed an extra ) for QBT_TR

@d47081
Copy link
Contributor

d47081 commented Nov 6, 2023

by the way I have fixed it in PR
#19888 (commit)

@luzpaz
Copy link
Contributor

luzpaz commented Nov 6, 2023

@d47081 please close this ticket if #19888 gets merged after review, TIA!

(next time you can add 'Fixes #19894' in the commit summary of the commit that fixes a different issue. This will auto-close the ticket, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Edit: my bad there was no ticket opened for this, just a PR.

@d47081
Copy link
Contributor

d47081 commented Nov 6, 2023

It was better to pull it from another branch on my side, I just worked on adaptive web UI (that includes lot of changes)
and found this bug too.

@glassez glassez changed the title QBT_TR remove extra ')' WebUI: Remove extra ')' in QBT_TR macro Nov 6, 2023
@glassez glassez requested a review from a team November 6, 2023 16:53
@glassez glassez added the WebUI WebUI-related issues/changes label Nov 6, 2023
@glassez glassez added this to the 4.6.1 milestone Nov 6, 2023
@xavier2k6
Copy link
Member

Might be no harm to update/modify uncrustify.cfg with latest upstream iterations to possibly catch things like this?!

A new codingStyleQtCreator.xml could also be generated?!

@glassez glassez merged commit 28b5d72 into qbittorrent:master Nov 8, 2023
13 checks passed
@glassez
Copy link
Member

glassez commented Nov 8, 2023

@itsnotv
Thank you!

glassez pushed a commit to glassez/qBittorrent that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants