Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: Correctly set save path in RSS rules #19916

Merged
merged 1 commit into from
Nov 11, 2023
Merged

WebUI: Correctly set save path in RSS rules #19916

merged 1 commit into from
Nov 11, 2023

Conversation

glassez
Copy link
Member

@glassez glassez commented Nov 10, 2023

Closes #19915.

@glassez glassez added WebUI WebUI-related issues/changes RSS RSS-related issues/changes labels Nov 10, 2023
@glassez glassez added this to the 4.6.1 milestone Nov 10, 2023
@glassez glassez requested a review from a team November 10, 2023 09:40
@glassez glassez mentioned this pull request Nov 10, 2023
Closed
@thalieht
Copy link
Contributor

thalieht commented Nov 10, 2023 •
edited

Can't reproduce problem in master, assuming the problem is what is shown in "Save to" isn't saved and not the actual save path for that rule i.e. torrents are not saved in what that field shows (can't test).

@glassez
Copy link
Member Author

glassez commented Nov 10, 2023

@thalieht
IIRC, it is reproducible only when Automatic torrent management mode is enabled by default. In that case qBittorrent just rejects save_path value. Note that WebUI doesn't provide complete UI for editing RSS rules currently so you can't override default TMM etc.

@thalieht
Copy link
Contributor

IIRC, it is reproducible only when Automatic torrent management mode is enabled by default.

It is... i guess i'm missing something else.

@glassez glassez merged commit fb497f3 into qbittorrent:master Nov 11, 2023
13 checks passed
@glassez glassez deleted the rss-web branch November 11, 2023 13:04
glassez added a commit to glassez/qBittorrent that referenced this pull request Nov 11, 2023
@glassez
WebUI: Correctly set save path in RSS rules
3007762 
PR qbittorrent#19916.
Closes qbittorrent#19915.
@glassez glassez mentioned this pull request Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalieht thalieht thalieht approved these changes

Assignees
No one assigned
Labels
RSS RSS-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

[Docker 4.6.0] RSS Rule save location does not save, even if other changes to the rule do save.
2 participants
@glassez @thalieht