-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: enforce coding styles #20828
WebUI: enforce coding styles #20828
Conversation
Chocobo1
commented
May 11, 2024
•
edited
Loading
edited
- WebUI: enforce string quotes coding style
- WebUI: enforce usage of const whenever possible
- WebUI: prefer arrow function in callbacks
- WebUI: use assignment operator shorthand
- WebUI: iterate over own properties only
- WebUI: simplify code
- WebUI: don't auto infer radix parameter
- WebUI: add missing break
@@ -30,6 +30,7 @@ export default [ | |||
"no-undef": "off", | |||
"no-unused-vars": "off", | |||
"no-var": "error", | |||
"prefer-arrow-callback": "error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to note that if any of these callbacks use this
, the behavior will change with this commit. I haven't gone through to audit usage of this
.
Please merge #20705 before this 😬 |
PR updated, resolved merge conflicts. |
I'm late here unfortunately, but for Summary in Enumerability and ownership of properties. |