Let the OS decide the default interface regardless of IPv4/IPv6. Closes #2156. #2611
Conversation
| @@ -1858,7 +1858,7 @@ void QBtSession::setListeningPort(int port) { | |||
| if (iface_name.isEmpty()) { | |||
| logger->addMessage(tr("qBittorrent is trying to listen on any interface port: %1", "e.g: qBittorrent is trying to listen on any interface port: TCP/6881").arg(QString::number(port)), Log::INFO); | |||
| if (listen_ipv6) | |||
| s->listen_on(ports, ec, "::", session::listen_no_system_port); | |||
| s->listen_on(ports, ec, 0, session::listen_no_system_port); | |||
There was a problem hiding this comment.
In the special case of "any interface" this should be used regardless of listen_ipv6.
|
Rename the commit message to something like Hint: |
|
done. |
Chocobo1
changed the title
|
@glassez I am willing to merge this. Are you ok with breaking your hacking? |
|
Ok. These small changes should not give me trouble. P.S. Please see my last PR as soon as possible - it should prevent some of further rebasing problems. |
|
@Chocobo1 sorry but can you rebase and fix the indentation? Normally I wouldn't knowingly break your commit, but the other one was too big and useful. Yours is tiny and you shouldn't have any problem rebasing. |
|
No problem, it's good to see code being uniformly formatted. |
|
Thank you. |
Let the OS decide the default interface regardless of IPv4/IPv6. Closes #2156.
|
Damn. The issue number had a typo... |
I like this idea. Even if we do not have such a config that satisfies our coding style, we could edit it as much as the other project files. |
|
Actually I have it lying in qbt's folder already(locally). Should I just push it? -as uncrustify.cfg- |
I think, Yes. You only need to warn other developers that it may contain discrepancies and need to double-check its work (until we bring it to perfection). |
See issue #2165.