Enables the -nox version to optionally run in the background #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,6 +160,20 @@ int main(int argc, char *argv[]) { | |||
| // Create Application | |||
| QString uid = misc::getUserIDString(); | |||
| #ifdef DISABLE_GUI | |||
| bool becomedaemon = false; | |||
There was a problem hiding this comment.
Please use camel case: "becomeDaemon", or even better "shouldDaemonize".
|
This functionality would be a great addition to qBittorrent! Thanks a lot. I hope you can take feedback into consideration and resubmit the pull request :) |
Added some suggestions for the previous commit from Christophe Dumez and made sure the argument directly after -d is looked at.
|
By movin the daemonizing 'till later in the code, qBittorrent will print 1 line to STDOUT when compiled with --enable-debug ("Preferences constructor"). But regular users won't compile with --enable-debug and everyone who does use --enable-debug will want to get as much info as possible so i am leaving it like this. |
cdumez
added a commit
that referenced
this pull request
Aug 19, 2012
Enables the -nox version to optionally run in the background
|
Thanks for the update. It is merged :) |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it more useful to run it in the background, here's a patch in case I'm not the only one...