Show/hide statusbar option #4029

takiz · 2015-10-30T13:07:52Z

It's usefull for small displays.

glassez · 2015-10-30T13:54:03Z

src/gui/mainwindow.cpp

@@ -1107,6 +1108,12 @@ void MainWindow::loadPreferences(bool configure_session)
        toolBar->setVisible(false);
    }

+    if (pref->isStatusbarDisplayed()) {


statusBar()->setVisible(pref->isStatusbarDisplayed());

glassez · 2015-10-30T13:59:37Z

@takiz Your changes are incomplete!
Status bar displays some information, which regularly updates. It makes no sense to do this when the statusbar is hidden.

Chocobo1 · 2015-10-30T14:00:49Z

src/gui/mainwindow.ui

+    <bool>true</bool>
+   </property>
+   <property name="text">
+    <string>Status bar</string>


bar -> Bar

And your screenshot doesn't show the correct capitalized menu items.

"Status bar" -> "Status Bar"

& missing?

You can give one if you want.

And screenshot the latest git version, not an outdated old version.

takiz · 2015-10-31T14:45:18Z

Status bar displays some information, which regularly updates. It makes no sense to do this when the statusbar is hidden.

In that case resource economy is low. It makes no sense.

glassez · 2015-11-01T06:29:51Z

@takiz You shouldn't create separate commits to fix the other commits from the current PR. This will pollute the qBittorrent history. Maintainer will not merge this.

sledgehammer999 · 2015-11-04T01:16:18Z

@takiz I presume you don't know much about git so I am giving you a few hints here on how to squash commits into one.

If you're on Windows you might want to setup a graphical editor for git. Terminal may not work correctly in interactive mode. (search google on how to do that)
Issue git rebase -i <hash>. This is the hash of the first(oldest) commit you want to manipulate. All the commits that follow it(newer commits) will be present in the list-> After you issue the command a file will open in your graphical editor. That file contains very good information on what is going on. Choose the "fixup" action for the relevant commits. (you'll understand once you see the file). For more info search google for "git interactive rebase".
After you're done merging commits, you need to update your branch that this PR is depended on. But because you re-wrote git history you need to do a forced push. Something like this git push --force origin statusbar. After that this PR will autoupdate.

sledgehammer999 · 2015-11-04T01:19:26Z

Also update your code to follow our style guide: https://github.com/qbittorrent/qBittorrent/blob/master/CODING_GUIDELINES.md
And at the first post of #2192 you can find a config for the uncrustify tool if you want to use that.

takiz · 2015-11-06T11:36:10Z

@sledgehammer999 done.

glassez · 2015-11-06T13:15:38Z

src/gui/mainwindow.cpp

@@ -1352,6 +1355,13 @@ void MainWindow::on_actionTop_tool_bar_triggered()
    Preferences::instance()->setToolbarDisplayed(is_visible);
 }

+void MainWindow::on_actionShow_Status_bar_triggered()
+{
+    bool is_visible = static_cast<QAction*>(sender())->isChecked();


Please use camelCased names.

ngosang · 2015-11-07T21:07:53Z

tested and looks good in linux with qt5.

sledgehammer999 · 2015-11-23T23:24:06Z

src/gui/mainwindow.cpp

+void MainWindow::on_actionShowStatusbar_triggered()
+{
+    bool isVisible = static_cast<QAction*>(sender())->isChecked();
+    QMainWindow::statusBar()->setVisible(isVisible);


use the status_bar member variable

sledgehammer999 · 2015-11-23T23:30:13Z

I think you should reimplement the showEvent() and hideEvent() in our StatusBar subclass and stop the timer when it is hidden. When shown you'll need to do a call to StatusBar::refreshStatusBar() too and start the timer (don't forget to remove those 2 commands from the constructor).

glassez · 2015-11-24T04:14:08Z

I think you should reimplement the showEvent() and hideEvent() in our StatusBar subclass and stop the timer when it is hidden. When shown you'll need to do a call to StatusBar::refreshStatusBar() too and start the timer (don't forget to remove those 2 commands from the constructor).

@sledgehammer999, what timer do you mean?

sledgehammer999 · 2015-11-24T07:16:07Z

The StatusBar class has a timer inside it and is used to update the speed info.

ngosang · 2015-12-22T23:25:31Z

@takiz any progress on this? could you rebase? Thanks.

ngosang · 2016-04-16T20:19:10Z

@takiz ping.

GUImodder · 2016-05-05T07:13:58Z

Hi,

i just wanted to ask when/if this option is going to be introduced in the stable releases? I just installed v. 3.3.4 and there is no option to hide the statusbar yet!
Best regards

GUImodder · 2016-05-06T07:43:10Z

Who decides whether this feature will be integrated or not? I mean: Whats the harm? Giving people more option can hardly be a bad thing?

GUImodder · 2016-05-07T12:00:07Z

Ok Thanks...and WHEN will he decide on this?

GUImodder · 2016-05-08T11:26:09Z

Ok thats sad...alot of users will jump ship in that case..

thalieht · 2016-08-04T09:22:24Z

There is always the option for anyone to take the PR, fix it and make a new PR.

ngosang · 2016-08-23T19:21:07Z

@takiz ??

glassez · 2017-05-25T13:42:44Z

I will finish it, if you do not mind.

glassez · 2017-05-25T13:43:53Z

Closing now. I'll open new PR with updated code.

Add show/hide statusbar option (Supersede #4029)

glassez reviewed Oct 30, 2015
View reviewed changes

Chocobo1 reviewed Oct 30, 2015
View reviewed changes

Chocobo1 mentioned this pull request Nov 1, 2015

Making the GUI fully/more customizable #3975

Closed

takiz force-pushed the statusbar branch from 21c06ed to 5aa63ca Compare November 6, 2015 11:29

glassez reviewed Nov 6, 2015
View reviewed changes

Show/hide statusbar option have been added

99a7297

takiz force-pushed the statusbar branch from 5aa63ca to 99a7297 Compare November 6, 2015 18:36

sledgehammer999 reviewed Nov 23, 2015
View reviewed changes

LordNyriox mentioned this pull request May 10, 2017

Steps for version 3.4 release #6767

Closed

glassez self-assigned this May 25, 2017

glassez closed this May 25, 2017

glassez mentioned this pull request May 25, 2017

Add show/hide statusbar option (Supersede #4029) #6840

Merged

glassez added a commit that referenced this pull request May 27, 2017

Merge pull request #6840 from glassez/statusbar

e367105

Add show/hide statusbar option (Supersede #4029)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show/hide statusbar option #4029

Show/hide statusbar option #4029

takiz commented Oct 30, 2015

glassez Oct 30, 2015

glassez commented Oct 30, 2015

Chocobo1 Oct 30, 2015

takiz Oct 31, 2015

Chocobo1 Oct 31, 2015

takiz Oct 31, 2015

takiz commented Oct 31, 2015

glassez commented Nov 1, 2015

sledgehammer999 commented Nov 4, 2015

sledgehammer999 commented Nov 4, 2015

takiz commented Nov 6, 2015

glassez Nov 6, 2015

ngosang commented Nov 7, 2015

sledgehammer999 Nov 23, 2015

sledgehammer999 commented Nov 23, 2015

glassez commented Nov 24, 2015

sledgehammer999 commented Nov 24, 2015

ngosang commented Dec 22, 2015

ngosang commented Apr 16, 2016

GUImodder commented May 5, 2016

GUImodder commented May 6, 2016

GUImodder commented May 7, 2016

GUImodder commented May 8, 2016

thalieht commented Aug 4, 2016

ngosang commented Aug 23, 2016

glassez commented May 25, 2017

glassez commented May 25, 2017

Show/hide statusbar option #4029

Show/hide statusbar option #4029

Conversation

takiz commented Oct 30, 2015

glassez Oct 30, 2015

Choose a reason for hiding this comment

glassez commented Oct 30, 2015

Chocobo1 Oct 30, 2015

Choose a reason for hiding this comment

takiz Oct 31, 2015

Choose a reason for hiding this comment

Chocobo1 Oct 31, 2015

Choose a reason for hiding this comment

takiz Oct 31, 2015

Choose a reason for hiding this comment

takiz commented Oct 31, 2015

glassez commented Nov 1, 2015

sledgehammer999 commented Nov 4, 2015

sledgehammer999 commented Nov 4, 2015

takiz commented Nov 6, 2015

glassez Nov 6, 2015

Choose a reason for hiding this comment

ngosang commented Nov 7, 2015

sledgehammer999 Nov 23, 2015

Choose a reason for hiding this comment

sledgehammer999 commented Nov 23, 2015

glassez commented Nov 24, 2015

sledgehammer999 commented Nov 24, 2015

ngosang commented Dec 22, 2015

ngosang commented Apr 16, 2016

GUImodder commented May 5, 2016

GUImodder commented May 6, 2016

GUImodder commented May 7, 2016

GUImodder commented May 8, 2016

thalieht commented Aug 4, 2016

ngosang commented Aug 23, 2016

glassez commented May 25, 2017

glassez commented May 25, 2017