fix previous commit

[ngaro]

• onFailure instead of onSuccess, otherwise the html doesn't start loading
• stop(), otherwise the html doesn't stop loading

[ngaro]

Well, actually i need neither onFailure nor onSuccess, it worked just fine without the onSuccess, i didn't see any racecondition. But it never worked for me with onSuccess.

[ngaro]

I'm not experienced in coupling javascript (i actually barely know any javascript) with c++, but if you think the race-condition happens because you can't be sure whether document.write or the shutting down will happen first then i don't think that's a problem. the javascript won't stop running when the c++ is shutdown first and the stop() in the javascript doesn't influence the shutting down of the c++

[cdumez]

I have committed a fix at 368ae43 to reply to the Web UI before calling qApp->exit(). This way, this should guarantee that onSuccess() is called on Web UI side (no race condition). Hopefully, it now works for you. The remaining issue is the need for stop(). I don't know what it does and it appears to work fine without it so I haven't added back yet. Please shade from light of this.

[ngaro]

I compiled your 368ae and noticed that:

• the exit button looks better where you placed it
• pressing it quits qbittorrent BUT the webpage telling that it's now
  longer running does not show.

If you compile my code and remove the stop() you will see that your browser
will still think that the page is loading after it's already visible (for
example, for firefox that loading-icon that looks like two arrows forming a
circle will keep turning )

I have committed a fix at 368ae43368ae43to reply to the Web UI before calling qApp->exit(). This way, this should
guarantee that onSuccess() is called on Web UI side (no race condition).
Hopefully, it now works for you. The remaining issue is the need for
stop(). I don't know what it does and it appears to work fine without it so
I haven't added back yet. Please shade from light of this.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/42#issuecomment-7871648.

[cdumez]

The webpage was showing just fine for me on Safari. I have just tried Chrome and it does not show. I'll debug this.

[ngaro]

I would use the src/webui/scripts/mocha-init.js from 0fe09aa and keep the
rest like it is now.

On Mon, Aug 20, 2012 at 7:21 PM, Christophe Dumez
notifications@github.comwrote:

The webpage was showing just fine for me on Safari. I have just tried
Chrome and it does not show. I'll debug this.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/42#issuecomment-7876491.

[cdumez]

I believe I have fixed the race condition in dac0d67. It would be great if you could give it a try.
I tried Safari, Chrome and Firefox: it works consistently on all of them now.

[ngaro]

works here too, let's keep it like this.

[cdumez]

Great. Thanks for testing.