-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling IPv6 should not disable IPv4 #4469
Conversation
The option to enable IPv6 should not disable operation on IPv4. Having an IPv6-only BitTorrent client is not useful today, the practical scenario for the foreseeable future is to utilize both protocols simultaneously (dual-stack).
|| (listenIPv6 && (protocol == QAbstractSocket::IPv4Protocol))) | ||
continue; | ||
if (!listenIPv6 && (protocol == QAbstractSocket::IPv6Protocol)) | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 spaces indentation
Offtopic, could you also help rewrite line 1457 |
This was done knowingly this way. At first I had similar code to yours but 2 things changed that:
In light of all these, I am closing this. If you have some counter argument I'll be happy to hear it. |
Now I think again, the current impl isn't enough to handle IPv6.
I could try to rewrite it, any other consideration? |
@Chocobo1 read the code more carefully. qbt doesn't assume ONE address is returned. Inside As I said, libtorrent listens only to one address at a time. If you set another it will stop listening to the previous one. So if the user has checked "Listen to IPv6 address" he really wants to listen to IPv6 only. Otherwise he would leave it empty. This PR would make sense if libtorrent indeed let us listen to multiple addresses. |
Yes, the try-until-success logic in When I said For example: eth0 has 2 valid IPv6 address
Well, I'm still not convinced by this idea. Most modern impl of IPv6 socket can also listen to IPv4 connection, see I'm not going to argue anymore, but if you know bittorrent protocol works otherwise (haven't read all BEPs), I am all ears. |
I misunderstood you. Yes, the above seems reasonable.
This has nothing to do with the bittorrent protocol. It is libtorrent that is limiting us. |
Unsubscribe me Sent from Yahoo Mail on Android On Tue, Dec 29, 2015 at 6:07 AM, romanrmnotifications@github.com wrote: You can view, comment on, or merge this pull request online at: Commit Summary
File Changes
Patch Links:
— |
@keith2015 you have to unsubscribe yourself. We can't. Come to this link and hit "unsubscribe" from the sidepanel. |
The option to enable IPv6 should not disable operation on IPv4. Having an IPv6-only BitTorrent client is not useful today, the practical scenario for the foreseeable future is to utilize both protocols simultaneously (dual-stack).