Do not create save folder in advance. Closes #5422

[glassez]

Do not create the save folder as long as the torrent will not start downloading.

[sledgehammer999]

Asking precautionary: You have tested now what the comment says, right?

[glassez]

Yes. Besides, I deal with move_storage() internals recently so I know exactly how it works.

[sledgehammer999]

Thank you then.

[sueridgepipe]

Release notes in the News section of the qBittorrent site says this bugfix was included in 3.3.6.

I have Do not start the download automatically checked and Pre-allocate disk space for all files is not checked in my settings. My understanding is with these settings that the base directories for added torrents should not be created.

I upgraded to 3.3.6 (Win8.1), added a couple of torrents, and their base directories were still created.

[glassez]

added a couple of torrents, and their base directories were still created.

Please describe in more detail what do you mean. How do you add torrents, where etc.

[sueridgepipe]

I downloaded a couple of torrent files into a monitored directory, specified in the settings.

I then started qBt which automatically added these torrents into the application. They are both multi-file torrents which will eventually be downloaded into their own directories. They do not start downloading immediately, as per the Do not start the download automatically setting, thus have a Status of Paused.

I immediately check in my qBt Default Save Path directory and both torrent content directories were created as part of the torrent add functionality. These directories are empty, which I would expect given Pre-allocate disk space for all files settings is not checked.

My understanding is these empty directories should not have been created.

[sueridgepipe]

Will this be fixed and included in the next release?

[sueridgepipe]

Hey glassez, you there? Your changes didn't work, are you going to fix?

[glassez]

Hey glassez, you there?

I'm unavailable at this time.

Your changes didn't work

I made some core changes here and they work. Apparently your problem is caused on some other application layer.

[sueridgepipe]

No they do not work... did you even test this?

Adding a torrent also creates the save directory, no matter how it is added.

With development & testing attitudes like yours is it any wonder qBt is riddled with bugs. You are far to concerned with protecting your precious ego than creating a quality FOSS app.

[glassez]

@sueridgepipe Well, where did you see my excessive concern for my ego?
I did not insult you. I just said that my change in this PR do not cover all the application and affect only its core.
And Yes, of cause, I did test it! Moreover, I've tested it just for you now: I added some multifile torrent, I uncheck "Start torrent" and qBittorrent did not create torrent content folder both in destination and incomplete folders.
But the problem you described may be caused by some other application level or subsystem (as I said above). Unfortunately, now I don't have the free time to find and fix it.

P.S. But if you're going to continue to speak out in your manner above, I prefer to end this discussion (and I will devote my free time drinking beer rather than fixing qBittorrent bugs).