Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save torrents queue in separate file #9883

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Conversation

glassez
Copy link
Member

@glassez glassez commented Nov 20, 2018

See #9556 for explanation.

  1. It saves/restores queue when "queuing" is enabled (unlike existing code). Is it acceptable change?
  2. When user disables "queuing" it just stops saving queue file. Should it remove/clear queue file?

@Chocobo1
Copy link
Member

When user disables "queuing" it just stops saving queue file. Should it remove/clear queue file?

I think yes, for the sake of more consistent program state when doing debugging.

src/base/base.pri Outdated Show resolved Hide resolved
Copy link
Member

@sledgehammer999 sledgehammer999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am done. I of course approve this. I'll test build it now. I'll comment again only if something's wrong with the test.

@sledgehammer999
Copy link
Member

Should this feature be backported to v4.1.x series?
(assuming that libtorrent 1.2.0 final won't be released soon)

@glassez
Copy link
Member Author

glassez commented Nov 25, 2018

Should this feature be backported to v4.1.x series?

I targeting it to v4.1.5 and scheduling removal of deprecated code to v4.2

@sledgehammer999
Copy link
Member

I targeting it to v4.1.5 and scheduling removal of deprecated code to v4.2

Depending on how many releases 4.1.x still has, the deprecation might be a bit too soon. I would target 4.2.2 or 4.2.3 for removal.

@glassez
Copy link
Member Author

glassez commented Nov 25, 2018

I would target 4.2.2 or 4.2.3 for removal.

Ok. No problem.
But I'm not sure we reach v4.2 soon (if it's sticks to libtorrent-1.2).

@qbittorrent qbittorrent deleted a comment from glassez Nov 25, 2018
@glassez
Copy link
Member Author

glassez commented Nov 26, 2018

All conversations are resolved so waiting for final review.

@glassez glassez merged commit 9e00f08 into qbittorrent:master Nov 28, 2018
@glassez glassez deleted the queue branch November 28, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants