Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui styling WIP #312

Merged
7 commits merged into from
Dec 13, 2017
Merged

Ui styling WIP #312

7 commits merged into from
Dec 13, 2017

Conversation

Stephen-Gates
Copy link
Contributor

Changes proposed in this pull request:

@Stephen-Gates
fix about close button colour
4c594de
@Stephen-Gates
UI restyling
e37c946 
- remove colon after label
- Capitalise labels
- Place labels above property entry (fixes #303)
- Make all data entry take 100% of panel width
- refine tooltips (replace #309, fixes #307)
- fix tooltip broken link
- relocate PK and FK data entry (fixes #286)
@Stephen-Gates Stephen-Gates added fn:Interface status:Ready 👋 This pull request is ready for review labels Dec 8, 2017
@Stephen-Gates Stephen-Gates added this to the v0.8.0 milestone Dec 8, 2017
@Stephen-Gates Stephen-Gates requested a review from a user December 8, 2017 10:16
@Stephen-Gates Stephen-Gates mentioned this pull request Dec 8, 2017
Closed
@Stephen-Gates
Copy link
Contributor Author

Could do with a tweak on the Constraints.

Note vertical alignment of text and text entry not aligned right.

screenshot 2017-12-08 20 21 26

@Stephen-Gates
move delete source button right
96f73ae 
just need to shift it up now
@Stephen-Gates Stephen-Gates changed the title Ui styling Ui styling WIP Dec 8, 2017
@Stephen-Gates Stephen-Gates removed the status:Ready 👋 This pull request is ready for review label Dec 8, 2017
@Stephen-Gates
Copy link
Contributor Author

Oh! Just noticed this

screenshot 2017-12-08 20 38 37

@Stephen-Gates
Copy link
Contributor Author

Almost there with help messages but noticed these two lines are not the same but probably should be (Note :class in TableProperties.vue)

This results in Package

  • right placement
  • no red highlight on box

screenshot 2017-12-09 07 27 43

and Table

  • wrong placement
  • red highlight on box

screenshot 2017-12-09 07 28 11

@mattRedBox can I get you're help on this?

@Stephen-Gates Stephen-Gates added the status:In-progress We're working on this right now label Dec 13, 2017
@ghost ghost merged commit df78bc6 into develop Dec 13, 2017
ghost pushed a commit that referenced this pull request Dec 13, 2017
Fixes #312.
cba2d69
ghost pushed a commit that referenced this pull request Dec 13, 2017
Fixes #299. Fixes #312.
6e3ea7f
@Stephen-Gates Stephen-Gates deleted the ui-styling branch December 13, 2017 20:57
@Stephen-Gates Stephen-Gates removed the status:In-progress We're working on this right now label Dec 15, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fn:Interface
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Package Tooltips not displaying Property Panel Styling Reorder table properties to match specification
1 participant
@Stephen-Gates