Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qdrant Client] Use Supported Models API #95

Closed
NirantK opened this issue Jan 17, 2024 · 1 comment
Closed

[Qdrant Client] Use Supported Models API #95

NirantK opened this issue Jan 17, 2024 · 1 comment
Assignees

Comments

@NirantK
Copy link
Contributor

NirantK commented Jan 17, 2024

The current Qdrant client uses a hard coded list of FastEmbed supported models. This creates a challenge that everytime we add a new model — we need to update two places: FastEmbed and the Qdrant client.

The better approach would be for the Qdrant Client to use the Supported models API from FastEmbed itself and use that. With pinned FastEmbed versions, this means that every new release of Qdrant client can support latest models which FastEmbed supports!

https://github.com/qdrant/qdrant-client/blob/efb876fe3915dc5e2855f60a5617e940c84591e5/qdrant_client/qdrant_fastembed.py#L18

@hiepxanh
Copy link

Yes I wish 1 is API interface an 2 is docker version for this, so I can deploy, restart and make it work on our workflow

@NirantK NirantK closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants