Skip to content

Commit

Permalink
gdbstub: Introduce gdb_handle_set_thread_user()
Browse files Browse the repository at this point in the history
The upcoming follow-fork-mode child support needs to perform certain
actions when GDB switches between the stopped parent and the stopped
child. Introduce a user-specific hook for this.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20240219141628.246823-10-iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240305121005.3528075-11-alex.bennee@linaro.org>
  • Loading branch information
iii-i authored and stsquad committed Mar 6, 2024
1 parent 6d92311 commit e454f2f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
11 changes: 9 additions & 2 deletions gdbstub/gdbstub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,7 @@ static void handle_cont_with_sig(GArray *params, void *user_ctx)

static void handle_set_thread(GArray *params, void *user_ctx)
{
uint32_t pid, tid;
CPUState *cpu;

if (params->len != 2) {
Expand All @@ -1116,8 +1117,14 @@ static void handle_set_thread(GArray *params, void *user_ctx)
return;
}

cpu = gdb_get_cpu(get_param(params, 1)->thread_id.pid,
get_param(params, 1)->thread_id.tid);
pid = get_param(params, 1)->thread_id.pid;
tid = get_param(params, 1)->thread_id.tid;
#ifdef CONFIG_USER_ONLY
if (gdb_handle_set_thread_user(pid, tid)) {
return;
}
#endif
cpu = gdb_get_cpu(pid, tid);
if (!cpu) {
gdb_put_packet("E22");
return;
Expand Down
1 change: 1 addition & 0 deletions gdbstub/internals.h
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ void gdb_handle_v_file_readlink(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_xfer_exec_file(GArray *params, void *user_ctx); /* user */
void gdb_handle_set_catch_syscalls(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_supported_user(const char *gdb_supported); /* user */
bool gdb_handle_set_thread_user(uint32_t pid, uint32_t tid); /* user */

void gdb_handle_query_attached(GArray *params, void *user_ctx); /* both */

Expand Down
5 changes: 5 additions & 0 deletions gdbstub/user.c
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,11 @@ void gdb_handle_query_supported_user(const char *gdb_supported)
{
}

bool gdb_handle_set_thread_user(uint32_t pid, uint32_t tid)
{
return false;
}

/*
* Execution state helpers
*/
Expand Down

0 comments on commit e454f2f

Please sign in to comment.