Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hedgehog-1.2 #63

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Support hedgehog-1.2 #63

merged 3 commits into from
Oct 24, 2022

Conversation

mbg
Copy link
Collaborator

@mbg mbg commented Sep 6, 2022 •
edited
Loading

Support hedgehog-1.2 and resolve #61.

@mbg mbg requested a review from gwils September 6, 2022 12:48
@mbg mbg self-assigned this Sep 6, 2022
@mbg mbg changed the title Support hedgehog-1.3 Support hedgehog-1.2 Sep 6, 2022
@gwils
Copy link
Member

gwils commented Sep 7, 2022 •
edited
Loading

might want to release #62 as a point release before this

I reckon we probably should, since this upcoming version will be a big cut-off point, at which some people will find themselves stuck.

Edit: Would you like to do this, or should I? I'm happy to.

CI failures, CPP

I would prefer us to support all GHC versions that our hedgehog bounds support, but I don't think it's worth the extra effort of adding CPP to support older hedgehog versions (and thereby older GHC versions). If someone needs to use an older version of hedgehog, they can use an older versions of tasty-hedgehog too.

@newhoggy newhoggy mentioned this pull request Sep 27, 2022
Merged
@mbg
Copy link
Collaborator Author

mbg commented Oct 3, 2022

@gwils I have pushed a version bump to 1.3.1 to master and uploaded a candidate release for the changes from #62.

@gwils
Copy link
Member

gwils commented Oct 4, 2022

Thank you! Feel free to release.

@spacekitteh
Copy link

What's stopping this from merging now that #62 is merged?

@mbg
Copy link
Collaborator Author

mbg commented Oct 12, 2022

Ah sorry, I think I was working on releasing this after I released the changes from #62 and got distracted by something. I will finish it now.

@mbg mbg marked this pull request as ready for review October 12, 2022 19:36
@mbg
Copy link
Collaborator Author

mbg commented Oct 12, 2022

@gwils this should be all good now. I have also uploaded a package candidate at https://hackage.haskell.org/package/tasty-hedgehog-1.4.0.0/candidate -- would be good to have someone sanity check that this all fine!

@ocharles
Copy link

I can give this a try on Monday if you don't mind waiting until then

@ocharles
Copy link

Alas, I can't easily test this right now because I need to upgrade hedgehog-classes in order to upgrade to Hedgehog 1.2 at work.

@gwils
Copy link
Member

gwils commented Oct 17, 2022

I have run the test suite on this branch on all the GHC versions we support, and they passed. I've asked a friend to test this version on his project.

@JackKelly-Bellroy
Copy link

We have a couple of packages that make light use tasty-hedgehog, and I was able to build and run their tests using 1609b31 (the current target of feature/skipping).

This was with GHC 9.2.4.

@JackKelly-Bellroy
Copy link

Actually, we have more than a couple, since tasty-discover seems to use it under the hood.

@mbg
Copy link
Collaborator Author

mbg commented Oct 24, 2022

It seems like this is probably good to merge, so I will do that now and release 1.4 on Hackage.

@mbg mbg merged commit 1ade0d8 into master Oct 24, 2022
@mbg mbg deleted the feature/skipping branch October 24, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwils gwils Awaiting requested review from gwils

Assignees

@mbg mbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Hedgehog Skipping
6 participants
@mbg @gwils @spacekitteh @ocharles @JackKelly-Bellroy @newhoggy