Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple panda robot #23

Closed
wants to merge 8 commits into from

Conversation

meinczingerm
Copy link

This PR contains changes necessary to add and control multiple Panda robots in the same env. I added a separate example.py where there is an example of how to add multiple robots and an example env+task to test the double panda arms. The example.py is only added for easy testing, but shouldn't be merged. It might make sense to add DoublePandaArm example into documentation, or somewhere else?

@meinczingerm
Copy link
Author

IMO the checks are only failing because of the example.py that should be removed anyway.

@qgallouedec qgallouedec linked an issue Apr 4, 2022 that may be closed by this pull request
@qgallouedec
Copy link
Owner

@meinczingerm
Copy link
Author

It is turned on.
image

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #23 (5fb4692) into master (76cc82e) will decrease coverage by 4.43%.
The diff coverage is 3.77%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   97.85%   93.42%   -4.44%     
==========================================
  Files          24       25       +1     
  Lines        1074     1125      +51     
==========================================
  Hits         1051     1051              
- Misses         23       74      +51     
Impacted Files Coverage Δ
example.py 0.00% <0.00%> (ø)
panda_gym/envs/robots/panda.py 100.00% <ø> (ø)
panda_gym/envs/core.py 97.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cc82e...5fb4692. Read the comment docs.

@qgallouedec
Copy link
Owner

Any update?

@meinczingerm
Copy link
Author

It seems, that this is only a conflict because of the coverage. The example.py could be removed if you don't want to have something similar somewhere.

@qgallouedec
Copy link
Owner

I made some comments on your changes, about typos and such, can you take a look?

@meinczingerm
Copy link
Author

I didn't notice. Yest I will look at it.

@mechtach714
Copy link

Good day,

Did you guys manage to get a second Franka added to the simulation? I'm trying to simulate object handover between two Franka arms and it would be wonderful if it would be a simple fix to include a second arm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature idea: multiple Panda robot in the same environment
3 participants