Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query building plugins.xml doesn't respect third component of version string #74

Open
azvoleff opened this issue Apr 28, 2020 · 2 comments
Assignees

Comments

@azvoleff
Copy link

The below line seems to ignore the third component of version strings:

filters.update({'pluginversion__min_qg_version__lte' : qg_version})

This means that a plugin with a minimum version requirement like 3.10.3 (as is the case for trends.earth - which depends on 3.10.3 or greater) doesn't show up on the plugin.xml page when QGIS queries the repository for plugins from versions of the software that are greater than or equal to 3.10.3 but less than 3.12. For example, see the page here which shows only the prior version of Trends.Earth, which doesn't have a third component to its minimum QGIS version requirement

I'd submit a pull request to fix but I'm not that familiar with Django, and also am not sure if this behavior is by design or a bug?

@sumandari
Copy link
Collaborator

sumandari commented Nov 26, 2020

Hi @azvoleff thank you for your input.

The page https://plugins.qgis.org/plugins/plugins.xml?qgis=3.10 does show trends.earth version 0.98.
The minimum QGIS version needed in order to run this particular plugin version is 3.10.0
So that it should be running on QGIS 3.10.
From your sample case, could you please clarify what version should be showed on that page?

plugins_tiket_74_fig_0

plugins_tiket_74_fig_1

@sumandari
Copy link
Collaborator

@timlinux @dimasciput

Do you think something wrong happened on server? when I'm running on my localmachine it will give expected result, but live server will give error a 404 page instead. https://plugins.qgis.org/plugins/plugins.xml?qgis=3.10.3

plugins_tiket_74_fig_2a
plugins_tiket_74_fig_2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants