Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default snapping on visible features #2595

Merged
merged 2 commits into from
May 7, 2018

Conversation

lbartoletti
Copy link
Member

@lbartoletti lbartoletti commented May 2, 2018

My first PR for the documentation 😃

I added a small paragraph to document my PR for the snapping on (in)visible features.
Fix #2594

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Really appreciated.

@@ -101,6 +101,7 @@ map view). While in the **Advanced** layer selection mode, it is possible to use
a snapping tolerance that refers to ``layer units``, the units of the reprojected
layer when 'on-the-fly' CRS transformation is on.

By default, only visible features can be snapped (the features whose style is displayed, except for layers where the symbology is "No symbols"). You can enable the snapping on invisible features by checking "Enable features for invisible features" under :menuselection:`Settings -->` |options| :menuselection:`Options --> Digitizing` tab
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split your text at around 80characters/row please? (would help commenting though i do it below)

  1. what about moving the text in parenthesis just after visible features? or get rid of it if we specify visible features in the map canvas (a kind of what you see is what you snap)? No strong opinion
  2. replace *"Enable features for invisible features" * by |unchecked| :guilabel:`Enable features for invisible features` (:guilabel: is used to indicate that it's a visual text on the application - with the hope that translators will use their equivalent in their language)
  3. the sentence should end with a period.

Also, you'd need to mention/list the checkbox option at https://docs.qgis.org/testing/en/docs/user_manual/introduction/qgis_configuration.html#digitizing-settings

@DelazJ DelazJ merged commit 787153c into qgis:master May 7, 2018
@DelazJ
Copy link
Collaborator

DelazJ commented May 7, 2018

Thanks @lbartoletti
And feel free to submit other doc fixes 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants