[training manual] Chapter 3 - Basic Maps #2847

ghtmtt · 2018-08-09T13:29:08Z

Other PR that updates the Chapter 3 - Basic Maps of the Training Manual:

try to be consistent with all the :guilabel: :kbd: etc
added more example (geometry generator)
added more exercises
all screenshots have been updated
new pictures added

This (and also other) PR will results in some conflict for the answer.rst file. I think it is better to start merging single PR and fix conflicts when needed.

yjacolin · 2018-08-14T14:20:41Z

source/docs/training_manual/answers/answers.rst

+* Click on the |signPlus| button to add another Symbol level.
+* Move the new symbol at the bottom of the list clicking the |arrowDown| button.
+* Choose a good color to fill the water polygons.
+* Click on Marker of the Geometry generator symbology and change the circle with


:guilabel:Marker

yjacolin · 2018-08-14T14:21:07Z

source/docs/training_manual/basic_map/symbology.rst

@@ -35,6 +35,10 @@ begin by changing the color of the :guilabel:`landuse` layer.
 .. note:: By default, you can also access a layer's properties by
   double-clicking on the layer in the Layers list.

+.. tip:: the button |symbology| in the upper part of the Layer Panel will open


The button...

yjacolin · 2018-08-14T14:21:54Z

source/docs/training_manual/basic_map/symbology.rst

@@ -56,7 +60,8 @@ A standard color dialog will appear.
 |basic| |TY|
 -------------------------------------------------------------------------------

-Change the :guilabel:`water` layer to a light blue color.
+Change the :guilabel:`water` layer to a light blue color. Try to use the Layer


Does the layer name (water) is considered as a guilabel?

AFAIK yes.. also in other chapter we considered layer names as guilabels. Other ideas?

DelazJ

Wouaw! a lot to follow.
General comment (related to the other PRs review): I'd favor multiple small PRs with compact changes, eg text updates/new exercises/.... This way it's easy (for us, maybe not for you 😄) to understand the changes and the relation between exercise and answer and screenshot
Also see writing guidelines at https://docs.qgis.org/testing/en/docs/documentation_guidelines/writing.html#inline-tags about guilabel or kbd usage

DelazJ · 2018-08-23T13:42:41Z

source/docs/training_manual/basic_map/symbology.rst

-  and select :guilabel:`Dashed Line` from the :guilabel:`Pen Style` dropdown.
-* Give the new, uppermost layer a thickness of :kbd:`1.3` and ensure that it is
-  a :guilabel:`Solid Line`.
+* Give the base line a :guilabel:`Stroke width` of :kbd:`2` and a black color


According to QGIS writing guidelines it should be ``2`` instead of :kbd: (some general documentation on the sphinx roles usage at http://www.sphinx-doc.org/en/stable/markup/inline.html#other-semantic-markup)

DelazJ · 2018-08-23T13:50:31Z

source/docs/training_manual/basic_map/vector_data.rst

@@ -42,28 +42,28 @@ coordinate plane. It is usually used to store discrete features, like roads and
 city blocks.


-.. _backlink-vector-load-shapefiles-1:
+.. _backlink-vector-load-geopackage-1:

 |basic| |FA| Loading Vector Data From Shapefiles


Is that the appropriate title? Actually it looks like the content of the section mixes shapefiles and gpkg information. Hard to follow to me.

my fault. Actually the section explains how to load geopackage layers, so the title is wrong

DelazJ · 2018-08-23T13:53:09Z

source/docs/training_manual/basic_map/vector_data.rst

@@ -73,24 +73,25 @@ same method:

 Databases allow you to store a large volume of associated data in one file. You
 may already be familiar with a database management system (DBMS) such as
-Microsoft Access. GIS applications can also make use of databases. GIS-specific
+Libreoffice Base. GIS applications can also make use of databases. GIS-specific


LibreOffice (but while I understand the intention, is that more meaningful than MS Access for most of our users?)

I was trying to avoid to mention Windows software :P

DelazJ · 2018-08-23T15:10:52Z

source/docs/training_manual/answers/answers.rst

@@ -58,7 +58,7 @@ Refer back to the :ref:`browser_panel_tm` and to :ref:`load_geopackage` sections
 |RF| *Working with Vector Data*
 -------------------------------------------------------------------------------

-.. _vector-load-shapefiles-1:
+.. _vector-load-geopackage-1:

 |basic| *Shapefiles*
 ...............................................................................


shapefile title but geopackage anchor?

right, done

DelazJ · 2018-08-23T15:16:30Z

source/docs/training_manual/basic_map/vector_data.rst

-name, but different file types. Shapefiles are easy to send back and forth, and
-most GIS software can read them.
+name, but different file types. GeoPackage layers are easy to send back and forth,
+and most GIS software can read them.


this description is not about gpkg

DelazJ · 2018-08-23T15:27:26Z

source/docs/training_manual/basic_map/vector_data.rst

@@ -101,6 +102,14 @@ database file on your computer.
 * Click on the :kbd:`landuse` layer to select it, then click
  :menuselection:`Add`

+Adding a layer from a SpatiaLite database or from a GeoPackage archive is not
+so different: in fact, both are spatial extension of the SQLite library.


My understanding was that we were focusing on shp vs gpkg so i fail to understand the steps using spatiaLite.
IMHO, first section should be about adding shapefiles, the next about adding same files from a gpkg db. Then, as a bonus, a note stating that spatiaLite is not that different from gpkg (for those that could be interested in exploring other formats). Did I get it wrong?

+0 . It is true that the main focus is on shp vs gpkg, but the chapter is not so specific. I think that a section mentioning SpatiaLite is worth to have.

Move a small paragraph with a comparison SL vs GP at the beginning of the section

DelazJ · 2018-08-23T15:31:42Z

source/docs/training_manual/basic_map/vector_data.rst

-the three buttons now reads "landuse.sqlite@...", followed by the path of the
-database file on your computer.
+
+Notice that the dropdown select above the three buttons now reads "landuse.sqlite@...",


drop**-**down ~~select~~?

DelazJ · 2018-08-23T15:32:26Z

source/docs/training_manual/basic_map/vector_data.rst

 * Click the :guilabel:`New` button.
-* In the same :file:`epsg4326` folder, you should find the file
+* In the same :file:`shapefiles` folder, you should find the file
  :file:`landuse.sqlite`. Select it and click :guilabel:`Open`.


weird to store a sqlite file in a folder named shapefiles...

correct. Moved outside the folder and put it in the main root. A PR will follow in the data repository.

DelazJ · 2018-08-23T15:36:10Z

source/docs/training_manual/answers/answers.rst

-* It is enough to change only the :guilabel:`water` layer for now. An example
-  is below, but may look different depending on the color you chose.
+* It is enough to select the :guilabel:`water` layer in the legend and then click
+  on the |symbology| button. Change the color with the one you want and best fits


can we add the tooltip whenever we use a button? This way, when the icon changes in the application and we do not yet update it, we can expect that at least the label would help readers...

ghtmtt

Done. I removed also a meaningless link to a not existing exercise.

ghtmtt · 2018-08-24T08:17:56Z

source/docs/training_manual/answers/answers.rst

@@ -58,7 +58,7 @@ Refer back to the :ref:`browser_panel_tm` and to :ref:`load_geopackage` sections
 |RF| *Working with Vector Data*
 -------------------------------------------------------------------------------

-.. _vector-load-shapefiles-1:
+.. _vector-load-geopackage-1:

 |basic| *Shapefiles*
 ...............................................................................


right, done

ghtmtt · 2018-08-24T08:22:53Z

source/docs/training_manual/basic_map/symbology.rst

@@ -56,7 +60,8 @@ A standard color dialog will appear.
 |basic| |TY|
 -------------------------------------------------------------------------------

-Change the :guilabel:`water` layer to a light blue color.
+Change the :guilabel:`water` layer to a light blue color. Try to use the Layer


AFAIK yes.. also in other chapter we considered layer names as guilabels. Other ideas?

ghtmtt · 2018-08-24T08:24:52Z

source/docs/training_manual/basic_map/vector_data.rst

@@ -42,28 +42,28 @@ coordinate plane. It is usually used to store discrete features, like roads and
 city blocks.


-.. _backlink-vector-load-shapefiles-1:
+.. _backlink-vector-load-geopackage-1:

 |basic| |FA| Loading Vector Data From Shapefiles


my fault. Actually the section explains how to load geopackage layers, so the title is wrong

ghtmtt · 2018-08-24T08:37:13Z

source/docs/training_manual/basic_map/vector_data.rst

@@ -73,24 +73,25 @@ same method:

 Databases allow you to store a large volume of associated data in one file. You
 may already be familiar with a database management system (DBMS) such as
-Microsoft Access. GIS applications can also make use of databases. GIS-specific
+Libreoffice Base. GIS applications can also make use of databases. GIS-specific


I was trying to avoid to mention Windows software :P

ghtmtt · 2018-08-24T08:39:27Z

source/docs/training_manual/basic_map/vector_data.rst

 * Click the :guilabel:`New` button.
-* In the same :file:`epsg4326` folder, you should find the file
+* In the same :file:`shapefiles` folder, you should find the file
  :file:`landuse.sqlite`. Select it and click :guilabel:`Open`.


correct. Moved outside the folder and put it in the main root. A PR will follow in the data repository.

ghtmtt · 2018-08-24T08:50:20Z

source/docs/training_manual/basic_map/vector_data.rst

@@ -101,6 +102,14 @@ database file on your computer.
 * Click on the :kbd:`landuse` layer to select it, then click
  :menuselection:`Add`

+Adding a layer from a SpatiaLite database or from a GeoPackage archive is not
+so different: in fact, both are spatial extension of the SQLite library.


+0 . It is true that the main focus is on shp vs gpkg, but the chapter is not so specific. I think that a section mentioning SpatiaLite is worth to have.

Move a small paragraph with a comparison SL vs GP at the beginning of the section

ghtmtt · 2018-09-08T07:16:02Z

Ok guys, I'm going to merge this so we can clean the cue. Thanks for the review @DelazJ @yjacolin

[training manual] Chapter 3 - Basic Maps

c9b8537

ghtmtt added the Training Manual label Aug 9, 2018

ghtmtt added this to the QGIS 3.4 milestone Aug 9, 2018

yjacolin reviewed Aug 14, 2018

View reviewed changes

DelazJ reviewed Aug 24, 2018

View reviewed changes

after first review

a2c5f62

ghtmtt commented Aug 24, 2018

View reviewed changes

ghtmtt merged commit d0e52d6 into qgis:master Sep 8, 2018

ghtmtt deleted the tm_chp3_basicmap branch September 10, 2018 06:25

DelazJ added the 3.4 QGIS 3.4 new features label Sep 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[training manual] Chapter 3 - Basic Maps #2847

[training manual] Chapter 3 - Basic Maps #2847

ghtmtt commented Aug 9, 2018

yjacolin Aug 14, 2018

yjacolin Aug 14, 2018

yjacolin Aug 14, 2018

ghtmtt Aug 24, 2018

DelazJ left a comment

DelazJ Aug 23, 2018

DelazJ Aug 23, 2018

ghtmtt Aug 24, 2018

DelazJ Aug 23, 2018

ghtmtt Aug 24, 2018

DelazJ Aug 23, 2018

ghtmtt Aug 24, 2018

DelazJ Aug 23, 2018

DelazJ Aug 23, 2018

ghtmtt Aug 24, 2018

DelazJ Aug 23, 2018

DelazJ Aug 23, 2018

ghtmtt Aug 24, 2018

DelazJ Aug 23, 2018

ghtmtt left a comment

ghtmtt Aug 24, 2018

ghtmtt Aug 24, 2018

ghtmtt Aug 24, 2018

ghtmtt Aug 24, 2018

ghtmtt Aug 24, 2018

ghtmtt Aug 24, 2018

ghtmtt commented Sep 8, 2018

[training manual] Chapter 3 - Basic Maps #2847

[training manual] Chapter 3 - Basic Maps #2847

Conversation

ghtmtt commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DelazJ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghtmtt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghtmtt commented Sep 8, 2018