Text for two CRS dialogues is wrong (swapped)

[qgib]

Author Name: Alister Hood (@AlisterH)
Original Redmine Issue: 4100
Affected QGIS version: 3.6.0
Redmine category:gui

---

Running trunk, when I have enabled "Settings>Options>CRS>Coordinate Reference System for new layers>Prompt for CRS", if I add a vector layer with no CRS then the dialogue says:
"Specify CRS for layer SOME_FILE_NAME"

When I right-click on a layer and choose "Set layer CRS", even if the layer does have a projection specification, the dialogue says:
"Define this layer's coordinate reference system:
This layer appears to have no projection specification. By default this layer will now have its projection set to that of the project, but you may override this by selecting a different projection below."

These two texts must have been mixed up.

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

• category_id was configured as Projection Support

[qgib]

Author Name: Alister Hood (@AlisterH)

---

There is a similar issue for raster layers. In this case, the correct text ("This layer appears to have no...") is shown when adding a layer with no CRS, but the same text is incorrectly shown when right-clicking on a layer with a CRS and choosing "Set layer CRS".

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• fixed_version_id was configured as Version 1.7.4

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

• fixed_version_id was changed from Version 1.7.4 to Version 1.8.0
• version was configured as master
• crashes_corrupts_data was configured as 0

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

• fixed_version_id was changed from Version 1.8.0 to Version 2.0.0

[qgib]

Author Name: Alister Hood (@AlisterH)

---

Also,
It seems that people coming from ArcGIS tend to expect "Specify CRS" to do something completely different. Rather than QGIS treating the data as if it is in the specified CRS, they expect it to do on-the-fly coordinate transformation to the specified CRS, so that calculations etc using that layer are done as if the layer had been transformed to that CRS.

Because of this it might be worth adding to the "Specify CRS for layer SOME_FILE_NAME" an explanation something like "N.B. this means QGIS will treat the layer as if its original data is actually in the specified CRS. It does not transform the data to the specified CRS."

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

• fixed_version_id was changed from Version 2.0.0 to Future Release - Lower Priority

[qgib]

Author Name: Médéric RIBREUX (Médéric RIBREUX)

---

Hello, bug triage...

still true for QGIS 2.13.

to fix this, we need to:

• modify the default message in "QgsGenericProjectionSelector::setMessage":

  QGIS/src/gui/qgsgenericprojectionselector.cpp

  Line 41 in beb4ffc

  void QgsGenericProjectionSelector::setMessage( QString theMessage )

• modify the code of QgisApp::validateSrs to add the previous generic message and also adding the validationHint words.

This should be an easy fix...

---

• tag was changed from to easy

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• easy_fix was configured as 0
• regression was configured as 0

[qgib]

Author Name: Alister Hood (@AlisterH)

---

Also see #14188 and #14783

---

• description was changed from Running trunk, when I have enabled "Settings>Options>CRS>Coordinate Reference System for new layers>Prompt for CRS", if I add a vector layer with no CRS then the dialogue says:
  "Specify CRS for layer SOME_FILE_NAME"

When I right-click on a layer and choose "Set layer CRS", even if the layer does have a projection specification, the dialogue says:
"Define this layer's coordinate reference system:
This layer appears to have no projection specification. By default this layer will now have its projection set to that of the project, but you may override this by selecting a different projection below."

These two texts must have been mixed up. to Running trunk, when I have enabled "Settings>Options>CRS>Coordinate Reference System for new layers>Prompt for CRS", if I add a vector layer with no CRS then the dialogue says:
"Specify CRS for layer SOME_FILE_NAME"

When I right-click on a layer and choose "Set layer CRS", even if the layer does have a projection specification, the dialogue says:
"Define this layer's coordinate reference system:
This layer appears to have no projection specification. By default this layer will now have its projection set to that of the project, but you may override this by selecting a different projection below."

These two texts must have been mixed up.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

End of life notice: QGIS 2.18 LTR
*
Source:*
http://blog.qgis.org/2019/03/09/end-of-life-notice-qgis-2-18-ltr/

---

• status_id was changed from Open to Closed
• resolution was changed from to end of life

[qgib]

Author Name: Alister Hood (@AlisterH)

---

Still valid for QGIS 3.6

---

• status_id was changed from Closed to Reopened

[qgib]

Author Name: Alister Hood (@AlisterH)

---

• resolution was changed from end of life to

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• status_id was changed from Reopened to Open
• category_id was changed from Projection Support to GUI
• version was changed from master to 3.6.0

[nyalldawson]

Fixed in recent versions

[AlisterH]

Fixed in recent versions

Subsequent to 3.10.2? Because it isn't fixed there.

[AlisterH]

For the record, these dialogs and various aspects of the behaviour are still inconsistent - and I can't believe everything is working as intended, although there are now 4 variations, not 2.

1. Dragging in a layer which doesn't define a CRS produces this version, which, incidentally, is unusual in that it shows the application name in the title bar:
   
   This one doesn't (but should) explain that it has been spawned because the layer doesn't have a CRS (if it is necessary to explain this in any of the other versions, it should be in this one too). Notably, the most recently chosen CRS is selected by default, not the project CRS, which is generally very helpful if you're loading a number of layers all at once.
   If I click cancel and so now have a layer without a CRS defined in the project:
   
2. Clicking on the question mark button produces this version, again with the application name in the title bar:
   
   Ideally the title bar would say "Set CRS for [layer name]".
   Notably this version does not have a CRS selected by default, so if you click OK without selecting a CRS, another dialog is produced the same as at number 1 (which must be confusing to people - "I thought it said it would set the CRS by default"), so shouldn't it just go straight to that version instead?
3. Doing instead Right-click>Layer CRS>Set Layer CRS, produces this version
   
   Again it doesn't have a CRS selected by default, so if you click OK without selecting a CRS it produces another dialog the same as at number 1. Ideally I think both here and in the other cases above you'd want something like this but with the most recently chosen CRS selected by default, and the wording should be revised to say that if you click Cancel a CRS is not set, and the layer will always be displayed as if it is in the current project CRS (whatever that happens to be):
4. If the layer already has a CRS and you go to change it, this is produced:
   
   The behaviour in this case is indeed fixed!