Composer forgets on/off status of layers ("Lock layers for map item" feature)

[qgib]

Author Name: Thaddeus - (Thaddeus -)
Original Redmine Issue: 4283

Assignee: Marco Hugentobler

---

Composer is one nifty features of QGIS: on my last project I had 238 layers and 21 composer pages, I had to redo the locked layer selection many, many, ... many times.

After playing with this (QGIS 1.6 and 1.7) I discovered that adding and removing layers is what triggers the Composer lock-layer amnesia, but it actually resets all Composers lock-layer values to what the main canvas has at the time of doing the add/remove layer operation.

To reproduce:

1. Open test data "ComposerLockLayerForgetfulness.qgs" and I get what I see on 0001.png.

2. Turn off all layers but one (see 0002.png).

3. Open "Composer 1" and refresh view if desired.

4. Add raster layer -- say included "google-roadmap-z0-2-13092011_172245.png" -- and I get what is shown on 0004.png.

---

• ComposerLockLayerForgetfulness.zip (Thaddeus -)
• 0001.png (Thaddeus -)
• 0002.png (Thaddeus -)
• 0003.png (Thaddeus -)
• 0004.png (Thaddeus -)
• fix_4283.patch (Nathan Woodrow)

[qgib]

Author Name: Thaddeus - (Thaddeus -)

---

• 3424 was configured as 0001.png

---

• 0001.png (Thaddeus -)

[qgib]

Author Name: Thaddeus - (Thaddeus -)

---

• 3425 was configured as 0002.png

---

• 0002.png (Thaddeus -)

[qgib]

Author Name: Thaddeus - (Thaddeus -)

---

• 3426 was configured as 0003.png

---

• 0003.png (Thaddeus -)

[qgib]

Author Name: Thaddeus - (Thaddeus -)

---

• 3427 was configured as 0004.png

---

• 0004.png (Thaddeus -)

[qgib]

Author Name: Nathan Woodrow (@NathanW2)

---

Attached is a patch that fixes the problem.

---

• category_id was configured as 33
• pull_request_patch_supplied was changed from 0 to 1
• fixed_version_id was configured as Version 1.7.1
• 3428 was configured as fix_4283.patch

---

• fix_4283.patch (Nathan Woodrow)

[qgib]

Author Name: Nathan Woodrow (@NathanW2)

---

• assigned_to_id was configured as Marco Hugentobler
• done_ratio was changed from 0 to 50

[qgib]

Author Name: Marco Hugentobler (@mhugent)

---

The composermap regularly checks for removed layers. The problem was that it didn't consider the non-visible layers if the layer-lock option was enabled and assumed those layers where deleted.
Fixed now in commit 820469f.

---

• done_ratio was changed from 50 to 100
• status_id was changed from Open to Closed