QGIS Server: Exclude composers in OWS tab does not work

[qgib]

Author Name: Andreas Neumann (@andreasneumann)
Original Redmine Issue: 8484
Affected QGIS version: master
Redmine category:qgis_server
Assignee: Marco Hugentobler

---

In the current QGIS server, if one uses a list of "Exclude composers" in the OWS tab, QGIS server lists only the excluded composers and not the composers the map author actually wants. So it acts as a white list and not as a black list.

Thank you for having a look at the problem!

[qgib]

Author Name: Marco Hugentobler (@mhugent)

---

• assigned_to_id was configured as Marco Hugentobler

[qgib]

Author Name: René-Luc ReLuc (@rldhont)

---

Will this bug be closed before QGIS 2 branching ?

[qgib]

Author Name: René-Luc ReLuc (@rldhont)

---

Hi Marco,

I have threw a glance at the code and the list of excluded composers is stored in the element WMSComposerList.

To fix this bug, we have several solutions :

1. Change the UI string and comments
2. Change the element name

Which has your preference ?

[qgib]

Author Name: Marco Hugentobler (@mhugent)

---

Hi René-Luc

My preference is to change the element name and the behaviour (currently whitelist -> blacklist). I think it is more usefull to have a list of not-published compositions rather than explicitely publishing every composition.

[qgib]

Author Name: René-Luc ReLuc (@rldhont)

---

OK, can I propose a patch or directly update master ?

[qgib]

Author Name: Andreas Neumann (@andreasneumann)

---

Hi,

Yes - the blacklist behaviour was already in place before this bug appeared. Also, I think the blacklist is what administrators want. Easier to maintain. Most of the composers would be public except some selected internal ones.

Thanks for providing the patch.

Andreas

[qgib]

Author Name: Marco Hugentobler (@mhugent)

---

OK, can I propose a patch or directly update master ?

Could you make a pull request on github?

[qgib]

Author Name: René-Luc ReLuc (@rldhont)

---

Pull request made :
#867

---

• done_ratio was changed from 0 to 100
• pull_request_patch_supplied was changed from 0 to 1

[qgib]

Author Name: Marco Hugentobler (@mhugent)

---

Works nicely, pushed to master branch. Thanks, René-Luc!

---

• status_id was changed from Open to Closed